Review request for 6432567: PIT : com/sun/jdi/BadHandshakeTest.java fails due to java.net.ConnectException
Daniel D. Daugherty
Daniel.Daugherty at Sun.COM
Thu Sep 3 08:21:49 PDT 2009
Alan Bateman wrote:
> Sorry for the delay getting back to this one. I've updated the webrev
> to address the comments, except for snprintf. The reason is that
> snprintf isn't in the Windows CRT. We usually use jio_snprintf
> (implemented on vsnprintf or _vsnprintf on Windows) but this is a
> transport library for the debugger agent and so isn't linked against
> the VM. We could extend its transport platform dependent code to add a
> function for this, but it hardly seems worth it for this one case.
In the following:
sprintf(msg, "handshake failed - received >%s< - helloLen >%s<", b, hello);
the "helloLen" above should probably be "hello".
Otherwise, thumbs up...
More information about the serviceability-dev