code review request for JVM/TI CompiledMethodLoad event extension (6580131)
Vasanth.Venkatachalam at amd.com
Mon Jan 11 13:40:44 PST 2010
Sorry I just noticed that you have modified jvmtiExport.cpp.
The changes look good to me.
From: Venkatachalam, Vasanth
Sent: Monday, January 11, 2010 3:30 PM
To: 'Daniel.Daugherty at Sun.COM'; Tom Rodriguez
Cc: Deneau, Tom; serviceability-dev at openjdk.java.net
Subject: RE: code review request for JVM/TI CompiledMethodLoad event extension (6580131)
Your changes look good.
As you may know, the JVM code will need to be modified to reflect the new naming conventions used in jvmticmlr.h. I believe the changes will be limited to the prims/jvmtiExport.cpp file.
I assume you'll be making these changes separately, since I didn't see a newer version of this file included in the webrev.
From: Daniel.Daugherty at Sun.COM [mailto:Daniel.Daugherty at Sun.COM]
Sent: Monday, January 11, 2010 3:02 PM
To: Tom Rodriguez
Cc: Venkatachalam, Vasanth; Deneau, Tom; serviceability-dev at openjdk.java.net
Subject: Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)
Thanks for the review! I did a merge with HSX-17 this AM and
that went very smoothly so I'm testing those bits right now.
I'm hoping to hear from Vasanth today, but he doesn't appear
to have an OpenJDK id so I can't list him as a reviewer; I
have listed him as a contributor.
I'm also hoping to hear from Kelly since my Makefile tweaks
were in stuff he knows...
Tom Rodriguez wrote:
This looks good to me. Thanks for your thorough work on this.
On Jan 11, 2010, at 11:28 AM, Daniel D. Daugherty wrote:
Second call for this code review request.
Daniel D. Daugherty wrote:
The folks at AMD Labs have been kind enough to provide an
extension to the JVM/TI CompileMethodLoad event in order
to provide additional information about in-lining. This
extension uses the existing (but previously unused)
Vasanth and company provided the HotSpot code changes and
the original demo program. I just did the Makefile changes
to export the new jvmticmlr.h file in the HotSpot repo and
the integration of the demo program into JAVA_HOME/demo/jvmti
in the JDK repo.
Here is the webrev for the OpenJDK6 version of the changes:
The OpenJDK7 version of these changes are not expected to be
very different from this version.
For the Sun folks, the CCC request for adding the jvmticmlr.h
is almost final. I'm waiting for the VM-SQE team to agree that
the latest version addresses their review concerns, but I
think the St Petersburg team is on holiday at the moment.
Any reviews are appreciated.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the serviceability-dev