Review request: 6765718: Indicate which thread throwing OOME when generating the heap dump at OOME
tomas.hurka at googlemail.com
Fri Sep 10 06:08:34 PDT 2010
> Thanks for taking care of this RFE!
You are welcome.
> line 1309 - please line up _oome_constructor with the rest since that's
> the style that in use in this part of the file
> line 1902 - typo 'out-of-memorry' -> 'out-of-memory'
> line 1974 - please add a comment for the oome parameter, e.g.,
> /* pass along out-of-memory-error flag */
> Any particular reason for changing the one HeapDumper ctr from
> public to private? Just curious...
According to the comment from Mandy, the second constructor
HeapDumper(bool gc_before_heap_dump, bool print_to_tty)
is not used. So I removed it and added new private constructor with oome flag.
> No comments.
> Please send this changeset to RT_Baseline through JPRT when you're
OK, I will do it.
The new webrev with above changes is here: <http://cr.openjdk.java.net/~thurka/6765718/webrev.02>
Tomas Hurka <mailto:tomas.hurka at sun.com>
NetBeans Profiler http://profiler.netbeans.org
Software Engineer, Developer Platforms Group
Sun Microsystems, Praha Czech Republic
More information about the serviceability-dev