Request for Review (S) : 7140868 TEST_BUG: jcmd tests need to use -XX:+UsePerfData
frederic.parain at oracle.com
Fri Feb 10 00:58:58 PST 2012
Thanks for the review.
I'd prefer to keep the $JCMD variable with only the
path to the jcmd binary, without any arguments.
Having the -J-XX:UsePerfData repeated on every jcmd
invocation is not necessarily a bad thing, it will remind
the reader that jcmd depends on the perfdata.
On 2/9/12 10:46 PM, David Holmes wrote:
> Hi Fred,
> On 9/02/2012 11:38 PM, Frederic Parain wrote:
>> Here's a very simple fix which adds -J-XX:+UsePerfData
>> to all jcmd test in order to pass with the embedded builds.
> Can't you redefine $JCMD to include the -J-XX:+UsePerfData so that it's
> needed in fewer places?
> Otherwise seems correct.
>> The CR:
>> The Webrev:
>> I've tested manually with embedded builds that adding
>> -J-XX:+UsePerfData is sufficient to pass the tests.
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at oracle.com
More information about the serviceability-dev