jmx-dev Codereview request: 8025207 Intermittent test failure: javax/management/monitor/CounterMonitorThresholdTest.java

[Daniel Fuchs]

On 9/23/13 8:27 PM, shanliang wrote:
> Hi,
>
> Please review this test fix, if the test continues failing, then we need
> to investigate the Monitor implementation.
>
> webrev: http://cr.openjdk.java.net/~sjiang/JDK-8025207/00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8025207
>
> Thanks,
> Shanliang
>

Hi Shanliang,

There seems to an issue in the exit condition of the loop in the
new code.

The old code had:

150  if (derivedGaugeValue.intValue() != derivedGauge[i])

the new code has:

155  } while (derivedGaugeValue.intValue() != counter[i]);


Also I'm not sure it's good idea to make a println every 100ms...

-- daniel