[8u-backport] RFR: JDK-8193879: Java debugger hangs on method invocation
fairoz.matte at oracle.com
Fri Oct 12 04:37:21 UTC 2018
Thanks for looking into it.
I have moved two methods (getTestSourcePath and parseBreakpoints) into Utils (existing helper class) class as part of testlibrary framework.
Now it makes sense to have both the methods as public.
Updated webrev - http://cr.openjdk.java.net/~fmatte/8193879/webrev.01/
From: JC Beyler <jcbeyler at google.com>
Sent: Thursday, October 11, 2018 9:23 PM
To: Fairoz Matte <fairoz.matte at oracle.com>
Cc: serviceability-dev at openjdk.java.net
Subject: Re: [8u-backport] RFR: JDK-8193879: Java debugger hangs on method invocation
The backport looks good to me (not a reviewer though) but I was wondering why you are porting the two methods (getTestSourcePath and parseBreakpoints) into this test? If we port other tests that would require it, would we be doing the same or factorizing the methods into a helper class ?
Last nit, those methods could be private no?
On Thu, Oct 11, 2018 at 6:22 AM Fairoz Matte <mailto:fairoz.matte at oracle.com> wrote:
Kindly review the backport of "JDK-8193879: Java debugger hangs on method invocation" to 8u
Code is almost cleanly applied, test case has been modified to fit into the JDK8 test framework.
Webrev - http://cr.openjdk.java.net/~fmatte/8193879/webrev.00/
JBS bug - https://bugs.openjdk.java.net/browse/JDK-8193879
JDK12 changeset - http://hg.openjdk.java.net/jdk/jdk/rev/218b5b64f102
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025365.html
More information about the serviceability-dev