RFR (M) 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
jcbeyler at google.com
Thu Oct 25 16:00:29 UTC 2018
For reference, after the space removal webrev has been pushed, this webrev
had a tiny conflict (as Chris had guessed) in one file:
You can see the old change vs the new change, it is trivial to see it is ok:
The full webrev is here:
If I could have a final LGTM, that would be awesome!
On Wed, Oct 24, 2018 at 2:26 PM serguei.spitsyn at oracle.com <
serguei.spitsyn at oracle.com> wrote:
> Hi Jc,
> It looks great!
> Your AI-enabled conversion scripts are smart! :)
> On 10/24/18 09:40, JC Beyler wrote:
> Hi all,
> Here is the first webrev to extract assignments from if test clauses. It
> should be relatively straightforward to review.
> I tested all the tests changed and they pass on my dev machine.
> Most changes were done via the script I put in the bug, I had to do a few
> clean-ups and corner cases as well.
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212884
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the serviceability-dev