<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Staffan,<br>
<br>
I probably don't have the full context here but what is the reason
for the "stop" command. I guess I'm just wondering why someone would
specify -f <file> with a stop command embedded. Also I wonder
if this file should support comment (# or whatever) so that they are
ignored by jcmd. Otherwise I agree with Nils command that the line
needs to be trimmed to ensure that it only contains "stop".<br>
<br>
-Alan<br>
<br>
On 21/05/2012 09:05, Staffan Larsen wrote:
<blockquote
cite="mid:70A91D48-D3F6-42B6-972C-7AEC8C4D6316@oracle.com"
type="cite">All,
<div><br>
</div>
<div>I need a Review of this change.
<div><br>
</div>
<div>Thanks,</div>
<div>/Staffan<br>
<div><br>
<div>
<div>On 11 maj 2012, at 12:42, Staffan Larsen wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space; ">New
webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Esla/7167157/webrev.01/">http://cr.openjdk.java.net/~sla/7167157/webrev.01/</a>
<div><br>
<div>
<div>On 11 maj 2012, at 12:17, Staffan Larsen
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word;
-webkit-nbsp-mode: space; -webkit-line-break:
after-white-space; ">Right. Should probably be
line.trim().equals("stop")
<div><br>
</div>
<div>/Staffan<br>
<div><br>
<div>
<div>On 11 maj 2012, at 11:41, Nils
Loodin wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap: break-word;
-webkit-nbsp-mode: space;
-webkit-line-break:
after-white-space; ">Should it be
"startsWith"? I don't know if we
ever plan to implement a command
that's called stopFeatureX, but
still..
<div><br>
</div>
<div>Regards,</div>
<div>Nils Loodin</div>
<div><br>
<div>
<div>On May 11, 2012, at 11:34 ,
Staffan Larsen wrote:</div>
<br
class="Apple-interchange-newline">
<blockquote type="cite">
<div style="word-wrap:
break-word;
-webkit-nbsp-mode: space;
-webkit-line-break:
after-white-space; ">Please
review the following fix
for the fix for 7154822.
Previously all lines in the
command file were sent to
the JVM as one string, but
the size limit was 1024
bytes so this was changed
in 7154822 to sending one
line at a time. Problem with
this is that the jcmd
utility keeps sending
commands even if it has
encountered a 'stop'. So
instead of relying on the
JVM to parse the 'stop'
command, we must now parse
this in the jcmd utility.
<div>
<div><br>
</div>
<div>webrev: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Esla/7167157/webrev.00/">http://cr.openjdk.java.net/~sla/7167157/webrev.00/</a></div>
</div>
<div><br>
</div>
<div>Thanks,</div>
<div>/Staffan</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>