<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
This version of webrev diff is messed up. Please ignore it.<br>
Will let you know when it is OK. <br>
<br>
Thanks for the suggestion I will test on Windows and OS X.<br>
<br>
Thanks<br>
Yumin<br>
<br>
On 2012/8/28 23:08, Staffan Larsen wrote:
<blockquote
cite="mid:F53856DF-440D-4D36-9ABF-B6E2A2B7BCA1@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<div>Yumin,</div>
<div><br>
</div>
The bsd makefiles are still not updated as far as I can see. I
think this should be tested on OS X and Windows as well as Linux
and Solaris before it goes in.
<div><br>
</div>
<div>Thanks,</div>
<div>/Staffan<br>
<div><br>
</div>
<div><br>
</div>
<div><br>
<div>
<div>On 29 aug 2012, at 01:48, Yumin Qi <<a
moz-do-not-send="true" href="mailto:yumin.qi@oracle.com">yumin.qi@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div bgcolor="#FFFFFF" text="#000000"> Hi, all <br>
<br>
Updated with feedback suggestions. Please have a look
again at the same link.<br>
<br>
Thanks<br>
Yumin<br>
<br>
<br>
<br>
<br>
On 2012/8/27 14:07, Yumin Qi wrote:
<blockquote cite="mid:503BE193.6090807@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
Hi, all<br>
<br>
Can I have you code review of <br>
6879063: SA should use hsdis for disassembly<br>
<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eminqi/6879063/">http://cr.openjdk.java.net/~minqi/6879063</a><br>
<br>
The SA has Java based disassemblers for x86 and
sparc but amd64. Instead of porting to amd64 we
should switch over to using hsdis for it like the JVM
does. This requires a new entry point into hsdis,
decode_instructions_virtual, which separates the
address of the code being disassembled from the buffer
containing the code. The existing uses of
decode_instructions have been updated to use the new
interface and SA Disassembler has Java native methods
that call into hsdis and call back up to Java to
perform the disassembly. Also changed makefile for
hsdis build for both(i386/amd64).<br>
<br>
All the old disassembler logic was deleted since
it's incompatible with the new disassembly interface.
Also deleted are dbx based SA interface and few other
dead files.<br>
<br>
Tested by dumping full assembly from core files.<br>
<br>
Reviewed-by:<br>
Contributed-by: Tom R (never)<br>
<br>
Thanks<br>
Yumin Qi<br>
<br>
</blockquote>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</blockquote>
</body>
</html>