<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 03/12/2013 11:53, Mattias Tobiasson wrote:
<blockquote cite="mid:14037e41-a9da-4c0b-842b-e95b8fe08617@default"
type="cite">
<style type="text/css">p { margin: 0; }</style>
<div style="font-family: Times New Roman; font-size: 12pt; color:
#000000">Hi,<br>
I have updated the patch after the review.<br>
<br>
webrev:<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~ykantser/6461635/webrev.04/">http://cr.openjdk.java.net/~ykantser/6461635/webrev.04/</a><br>
<br>
Changes:<br>
1. Removed BasicTests.sh from ProblemList<br>
2. Use sun.tools.jar.Main to create jars.<br>
3. Application.java uses try-with-resources.<br>
4. Changed name of nested test class from Impl to TestMain.<br>
</div>
</blockquote>
I looks at the updated webrev and the changes look good.<br>
<br>
One other opportunity for try-with-resources is in
RunnerUtil.readFile, I didn't notice this in previous round. Better
still would be use Files.readAllBytes to read the file in one call,
or readAllLines if the file may be composed of several lines. This
is just a minor point so no need to re-generate the webrev if you
change anything here.<br>
<br>
I see Staffan is going to sponsor this for you.<br>
<br>
-Alan<br>
</body>
</html>