<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Looks good!</div><div><br></div><div>Thanks,</div><div>/Staffan</div><div><br></div><div><div>On 20 jan 2014, at 15:51, Olivier Lagneau <<a href="mailto:olivier.lagneau@oracle.com">olivier.lagneau@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
<div bgcolor="#ffcc99" text="#000099">
Please review the following simple fix.<br>
<br>
Issue: <a href="https://bugs.openjdk.java.net/browse/JDK-8019389">https://bugs.openjdk.java.net/browse/JDK-8019389</a><br>
Webrev: <a href="http://cr.openjdk.java.net/%7Eolagneau/8019389/webrev.00/">http://cr.openjdk.java.net/~olagneau/8019389/webrev.00/</a><br>
<br>
The issue is due to the fact that _invokeHandle bytecode is
generated by hotspot,<br>
but is not declared in agent code. Just declaring the new bytecode
solves the assertion failure.<br>
<br>
However the tests reported in 8019389
(bootstrapOtherStratumInStackTrace, targetOtherStratumInStackTrace)<br>
suffer the problem from <a href="https://bugs.openjdk.java.net/browse/JDK-7016268">JDK-7016268</a>
<font color="#3333ff">: Can't get strata information through SA-JDI</font><br>
Thus, the "stratum mismatch" related to JDK-7016268 will still be
present after fix.<br>
This second problem has to be fixed through JDK-7016268.<br>
<br>
Thanks,<br>
Olivier.<br>
</div>
</blockquote></div><br></body></html>