<html><head></head><body><div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; background-color: white;">Thank you Daniel. I will run and update it with the result.<br>
<br>
</div>
<div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; background-color: white;">Regards,<br>
</div>
<div dir="auto" style="direction: ltr; margin: 0; padding: 0; font-family: sans-serif; font-size: 11pt; color: black; background-color: white;">Shafi</div>
<br><br><br>
<div class="gmail_quote">On Tue, Sep 5, 2017 at 9:44 PM +0530, "Daniel D. Daugherty" <span dir="ltr"><<a href="mailto:daniel.daugherty@oracle.com" target="_blank">daniel.daugherty@oracle.com</a>></span> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="3D"ltr"">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<tt>Seems like you should also run: nsk.monitoring.testlist<br>
<br>
Dan<br>
<br>
</tt><br>
<div class="moz-cite-prefix">On 9/4/17 4:11 AM, Shafi Ahmad wrote:<br>
</div>
<blockquote type="cite" cite="mid:131072bd-7d03-4f79-8ca0-6c26f9bbe315@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the fix for ‘JDK-8170299:
Debugger does not stop inside the low memory notifications
code’ to jdk10.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">With the current implementation ‘debugger
does not stop inside the low memory *notifications* code’ <o:p></o:p></p>
<p class="MsoNormal">This is expected as the notification code
is getting executed with the service thread, which is a hidden
thread.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">jdk10-dev-new$ jdb -Xmx32m
MemoryWarningSystem<o:p></o:p></p>
<p class="MsoNormal">Initializing jdb ...<o:p></o:p></p>
<p class="MsoNormal">> stop at MemoryWarningSystem$1:25<o:p></o:p></p>
<p class="MsoNormal">Deferring breakpoint
MemoryWarningSystem$1:25.<o:p></o:p></p>
<p class="MsoNormal">It will be set after the class is loaded.<o:p></o:p></p>
<p class="MsoNormal">> run<o:p></o:p></p>
<p class="MsoNormal">run MemoryWarningSystem<o:p></o:p></p>
<p class="MsoNormal">Set uncaught java.lang.Throwable<o:p></o:p></p>
<p class="MsoNormal">Set deferred uncaught java.lang.Throwable<o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">. . .<o:p></o:p></p>
<p class="MsoNormal">> quit<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Breakpoint not hit.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">With the attached webrev, jdb stop at
breakpoint inside notification code.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">jdk10-dev-new$ jdb -Xmx64m
MemoryWarningSystem<o:p></o:p></p>
<p class="MsoNormal">Initializing jdb ...<o:p></o:p></p>
<p class="MsoNormal">> stop at MemoryWarningSystem$1:25<o:p></o:p></p>
<p class="MsoNormal">Deferring breakpoint
MemoryWarningSystem$1:25.<o:p></o:p></p>
<p class="MsoNormal">It will be set after the class is loaded.<o:p></o:p></p>
<p class="MsoNormal">> run<o:p></o:p></p>
<p class="MsoNormal">run MemoryWarningSystem<o:p></o:p></p>
<p class="MsoNormal">Set uncaught java.lang.Throwable<o:p></o:p></p>
<p class="MsoNormal">Set deferred uncaught java.lang.Throwable<o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">VM Started: Set deferred breakpoint
MemoryWarningSystem$1:25<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Breakpoint hit: "thread=Thread-0",
MemoryWarningSystem$1.memoryUsageLow(), line=25 bci=0<o:p></o:p></p>
<p class="MsoNormal">25 System.out.println("Memory
usage low!!!");<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thread-0[1] step<o:p></o:p></p>
<p class="MsoNormal">> Memory usage low!!!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Step completed: "thread=Thread-0",
MemoryWarningSystem$1.memoryUsageLow(), line=26 bci=8<o:p></o:p></p>
<p class="MsoNormal">26 double percentageUsed =
((double) usedMemory) / maxMemory;<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thread-0[1] where<o:p></o:p></p>
<p class="MsoNormal"> [1] MemoryWarningSystem$1.memoryUsageLow
(MemoryWarningSystem.java:26)<o:p></o:p></p>
<p class="MsoNormal"> [2]
MemoryWarningSystem$2.handleNotification
(MemoryWarningSystem.java:48)<o:p></o:p></p>
<p class="MsoNormal"> [3]
javax.management.NotificationBroadcasterSupport.handleNotification
(NotificationBroadcasterSupport.java:284)<o:p></o:p></p>
<p class="MsoNormal"> [4]
javax.management.NotificationBroadcasterSupport$SendNotifJob.run
(NotificationBroadcasterSupport.java:361)<o:p></o:p></p>
<p class="MsoNormal"> [5] java.lang.Thread.run
(Thread.java:844)<o:p></o:p></p>
<p class="MsoNormal">Thread-0[1] step<o:p></o:p></p>
<p class="MsoNormal">> <o:p></o:p></p>
<p class="MsoNormal">Step completed: "thread=Thread-0",
MemoryWarningSystem$1.memoryUsageLow(), line=27 bci=15<o:p></o:p></p>
<p class="MsoNormal">27
System.out.println("percentageUsed = " + percentageUsed);<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thread-0[1] list<o:p></o:p></p>
<p class="MsoNormal">23 mws.addListener(new
MemoryWarningSystem.Listener() {<o:p></o:p></p>
<p class="MsoNormal">24 public void memoryUsageLow(long
usedMemory, long maxMemory) {<o:p></o:p></p>
<p class="MsoNormal">25 System.out.println("Memory
usage low!!!");<o:p></o:p></p>
<p class="MsoNormal">26 double percentageUsed =
((double) usedMemory) / maxMemory;<o:p></o:p></p>
<p class="MsoNormal">27 =>
System.out.println("percentageUsed = " + percentageUsed);<o:p></o:p></p>
<p class="MsoNormal">28
MemoryWarningSystem.setPercentageUsageThreshold(0.8);<o:p></o:p></p>
<p class="MsoNormal">29 }<o:p></o:p></p>
<p class="MsoNormal">30 });<o:p></o:p></p>
<p class="MsoNormal">31 <o:p></o:p></p>
<p class="MsoNormal">32 Collection<Double> numbers
= new LinkedList<Double>();<o:p></o:p></p>
<p class="MsoNormal">Thread-0[1]<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">In the change, the class ‘MemoryImpl’ is
derived from class ‘NotificationBroadcasterSupport’ instead of
class ‘NotificationEmitterSupport’ <o:p></o:p></p>
<p class="MsoNormal">NotificationBroadcastSupport takes an
Executor, MemoryImpl constructor call super() with an
executor, a visible thread.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The method hasListeners() is referenced
inside MemoryImpl.java and defined in
NotificationEmitterSupport.<o:p></o:p></p>
<p class="MsoNormal">This method is not present in
NotificationBroadcasterSupport so I added it to
NotificationBroadcasterSupport.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Jdk10 bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8170299" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8170299</a><o:p></o:p></p>
<p class="MsoNormal">Webrev link: <a href="http://cr.openjdk.java.net/%7Eshshahma/8170299/webrev.01/" moz-do-not-send="true">http://cr.openjdk.java.net/~shshahma/8170299/webrev.01/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Testing: jprt -testset core, vm tonga tests
nsk.jvmti.testlist, nsk.jdi.testlist, nsk.jdwp.testlist and
jtreg tests ./jdk/test/com/sun/jdi/<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please let me know if I missed to test some
more test suit[s].<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks to Mandy and Poonam for helping me
in fixing this. <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Shafi<o:p></o:p></p>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
</body></html>