<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 08/03/2018 07:27, Amit Sapre wrote:<br>
<blockquote type="cite"
cite="mid:bb28e3dd-88c8-4f11-93ec-b8c55a3676f4@default">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hello,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please review the changes for removing SNMP
support.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Bug ID : <a
href="https://bugs.openjdk.java.net/browse/JDK-8071367"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8071367</a>
<o:p></o:p></p>
<p class="MsoNormal">Webrev : <a
href="http://cr.openjdk.java.net/%7Easapre/webrev/2018/JDK-8071367/webrev.00"
moz-do-not-send="true">http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.00</a></p>
</div>
</blockquote>
cc'ing compiler-dev for help on javac/resources/legacy.properties.
I'm not 100% sure if it is used when compiling to old releases or
not.<br>
<br>
As you are re-wording the class description for
jdk.internal.agent.Agent then we might as well get it right. The
Agent class loaded and its static no-arg startAgent method is
invoked when a system property starting with "com.sun.management" is
specified on the command line. We could expand this to include the
case where it is started in a running VM too.<br>
<br>
build.properties - I assume the empty value for excludes shouldn't
have a continuation character now.<br>
<br>
The rest looks good to me.<br>
<br>
-Alan.<br>
<br>
<br>
</body>
</html>