<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi Jc,<br>
      <br>
      <br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Ejcbeyler/8211801/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP06/ap06t001/ap06t001.cpp.udiff.html">http://cr.openjdk.java.net/%7Ejcbeyler/8211801/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP06/ap06t001/ap06t001.cpp.udiff.html</a><br>
      <br>
      <pre>         if (!NSK_JNI_VERIFY(jni, (fid =
<span class="removed">-                NSK_CPP_STUB4(GetStaticFieldID, jni,</span>
<span class="removed">-                                                debugeeClass,</span>
<span class="removed">-                                                "thread",</span>
<span class="removed">-                                                THREAD_CLS_SIGNATURE)) != NULL )) {</span>
<span class="new">+                jni->GetStaticFieldID(debugeeClass, "thread", THREAD_CLS_SIGNATURE)) != NULL )) {</span>
             nsk_jvmti_setFailStatus();
             break;
         }
 
         if (!NSK_JNI_VERIFY(jni, (localRefThread =
<span class="removed">-                NSK_CPP_STUB3(GetStaticObjectField, jni,</span>
<span class="removed">-                                                    debugeeClass,</span>
<span class="removed">-                                                    fid )) != NULL )) {</span>
<span class="new">+                jni->GetStaticObjectField(debugeeClass, fid)) != NULL )) {</span>
             NSK_COMPLAIN0("GetStaticObjectField returned NULL for 'thread' field value\n\n");
             nsk_jvmti_setFailStatus();
             break;
         }

  Could you, please, remove extra space after NULL.
</pre>
      <br>
      In many-many files (especially, in the foleder:
      scenarios/capability):<br>
      <pre><span class="new">+    if (!NSK_JVMTI_VERIFY_CODE(JVMTI_ERROR_MUST_POSSESS_CAPABILITY,jvmti->SuspendThread(thread)))
...
</span><span class="new">+    if (!NSK_JVMTI_VERIFY_CODE(JVMTI_ERROR_MUST_POSSESS_CAPABILITY,jvmti->ResumeThread(thread)))
...
</span><span class="new">+    if (!NSK_JVMTI_VERIFY_CODE(JVMTI_ERROR_MUST_POSSESS_CAPABILITY,jvmti->InterruptThread(thread)))</span>
<span class="new"></span><span class="new"></span></pre>
      <br>
      There are a lot of cases like above where a space before
      jvmti-> is missed.<br>
      <br>
      <br>
      Otherwise, looks good.<br>
      <br>
      <br>
      Thanks!<br>
      Serguei<br>
      <br>
      <br>
      On 10/5/18 16:50, JC Beyler wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAF9BGByqBj4WCqHSN4RPAbSqYv5wTUL5m=UEkbuBq7aV8tWXQg@mail.gmail.com">
      <div dir="ltr">
        <div dir="ltr">
          <div dir="ltr">
            <div dir="ltr">Hi all,
              <div><br>
              </div>
              <div>I continued the NSK_CPP_STUB removal with this next
                webrev.<br>
              </div>
              <div><br>
              </div>
              <div>My apologies, this one is big for 50 files; I can
                further cut it up if we prefer. It is straight-forward
                though, since it is just doing the same NSK_CPP_STUB
                removal.</div>
              <div><br>
              </div>
              <div>Without further ado:</div>
              <div>Webrev: <a
                  href="http://cr.openjdk.java.net/%7Ejcbeyler/8211801/webrev.00/"
                  moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8211801/webrev.00/</a></div>
              <div>Bug: <a
                  href="https://bugs.openjdk.java.net/browse/JDK-8211801"
                  moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8211801</a></div>
              <div><br>
              </div>
              <div>
                <div dir="ltr"
class="gmail-m_4350138340315380472gmail-m_-5052348339937521290gmail_signature">
                  <div dir="ltr">
                    <div>This does another 50 file batch. I did the same
                      for <a
                        href="https://bugs.openjdk.java.net/browse/JDK-8211782"
                        moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8211782</a>
                      so the scripts can be found there (and added a
                      comment in this bug to link to that).</div>
                    <div><br>
                    </div>
                    <div>I've tested the modified changes on my machine,
                      all modified tests pass.<br>
                    </div>
                    <div><br>
                    </div>
                    Let me know what you think,
                    <div>Jc</div>
                  </div>
                </div>
              </div>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>