<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi JC,<br>
      <br>
      iterinstcls006.cpp: Can you fix the indentation of the second
      line.<br>
      <br>
        98             NSK_COMPLAIN2("Local storage was corrupted: %s
      ,\n\texpected value: %s\n",<br>
        99                              (char *)storage_ptr,
      storage_data);<br>
      <br>
      iterobjreachobj004.cpp: Can you fix the indentation of the second
      line.<br>
      <br>
       123             NSK_COMPLAIN2("Local storage was corrupted: %s
      ,\n\texpected value: %s\n",<br>
       124                              (char *)storage_ptr,
      storage_data);<br>
      <br>
      iterreachobj002.cpp: You didn't align the arguments like you have
      elsewhere.<br>
      <br>
       175
      stackReferenceCallbackForSecondObjectsIteration(jvmtiHeapRootKind
      root_kind,<br>
       176                          jlong     class_tag,<br>
       177                          jlong     size,<br>
       178                          jlong*    tag_ptr,<br>
       179                          jlong     thread_tag,<br>
       180                          jint      depth,<br>
       181                          jmethodID method,<br>
       182                          jint      slot,<br>
       183                          void*     user_data) {<br>
      <br>
      iterreachobj004.cpp: Can you fix the indentation of the second
      line.<br>
      <br>
        75         NSK_COMPLAIN2("heapRootCallback: Local storage was
      corrupted: %s ,\n\texpected value: %s\n",<br>
        76                          (char *)storage_ptr, storage_data);<br>
      <br>
       119         NSK_COMPLAIN2("stackReferenceCallback: Local storage
      was corrupted: %s ,\n\texpected value: %s\n",<br>
       120                          (char *)storage_ptr, storage_data);<br>
      <br>
       162         NSK_COMPLAIN2("objectReferenceCallback: Local storage
      was corrupted: %s ,\n\texpected value: %s\n",<br>
       163                          (char *)storage_ptr, storage_data);<br>
      <br>
      thanks,<br>
      <br>
      Chris<br>
      <br>
      On 10/19/18 1:49 PM, JC Beyler wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAF9BGBzitJLNKn0s08tRE1Brd2+-zC07nxpf3HtXwu2_D_+r1w@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <div dir="ltr">
        <div dir="ltr">Hi all,
          <div><br>
          </div>
          <div>Sorry about the spam; forgot to add the subject :)</div>
          <div><br>
          </div>
          <div>
            <div dir="ltr">
              <div>Here is the first of three webrevs to remove spaces
                around (); I also removed any space after !.</div>
              <div><br>
              </div>
              <div>When the change modified where future parameters
                should be indented, I changed those too (such as <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html"
                  target="_blank" moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html</a>)</div>
              <div><br>
              </div>
              Webrev: <a
                href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/"
                moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/</a></div>
            <div dir="ltr">Bug: <a
                href="https://bugs.openjdk.java.net/browse/JDK-8212535"
                target="_blank" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8212535</a><br
                clear="all">
              <br>
            </div>
          </div>
          <div>Thanks!</div>
          <div>Jc<br>
            <br>
            <div class="gmail_quote">
              <div dir="ltr">On Fri, Oct 19, 2018 at 1:47 PM JC Beyler
                <<a href="mailto:jcbeyler@google.com"
                  moz-do-not-send="true">jcbeyler@google.com</a>>
                wrote:<br>
              </div>
              <blockquote class="gmail_quote" style="margin:0px 0px 0px
                0.8ex;border-left:1px solid
                rgb(204,204,204);padding-left:1ex">
                <div dir="ltr">
                  <div dir="ltr">
                    <div dir="ltr">
                      <div dir="ltr">
                        <div>Hi all,</div>
                        <div><br>
                        </div>
                        <div>Here is the first of three webrevs to
                          remove spaces around (); I also removed any
                          space after !.</div>
                        <div><br>
                        </div>
                        <div>When the change modified where future
                          parameters should be indented, I changed those
                          too (such as <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html"
                            target="_blank" moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html</a>)</div>
                        <div><br>
                        </div>
                        Webrev: <a
                          href="https://bugs.openjdk.java.net/browse/JDK-8212535"
                          target="_blank" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8212535</a></div>
                      <div dir="ltr">Bug: <a
                          href="https://bugs.openjdk.java.net/browse/JDK-8212535"
                          target="_blank" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8212535</a><br
                          clear="all">
                        <div><br>
                        </div>
                        <div dir="ltr"
                          class="gmail-m_-4710772905289707632gmail_signature">
                          <div dir="ltr">Let me know what you think,
                            <div>Jc</div>
                          </div>
                        </div>
                      </div>
                    </div>
                  </div>
                </div>
              </blockquote>
            </div>
            <br>
          </div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
  </body>
</html>