<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <tt>I have requested backport to 11u and pending for approval.<br>
      <br>
      Mandy<br>
    </tt><br>
    <div class="moz-cite-prefix">On 10/25/18 10:16 AM, Sven Reimers
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAP+Jvx4qTG2BvB-+nrWVaitrSKhv9Fk_z90gwupw2m7Qk8w0bA@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <div dir="ltr">Hi Mandy,
        <div><br>
        </div>
        <div>will this be backported to 11?</div>
        <div><br>
        </div>
        <div>Sven</div>
      </div>
      <br>
      <div class="gmail_quote">
        <div dir="ltr">On Thu, Oct 25, 2018 at 10:10 AM Mandy Chung <<a
            href="mailto:mandy.chung@oracle.com" moz-do-not-send="true">mandy.chung@oracle.com</a>>
          wrote:<br>
        </div>
        <blockquote class="gmail_quote" style="margin:0 0 0
          .8ex;border-left:1px #ccc solid;padding-left:1ex">
          <div bgcolor="#FFFFFF" text="#000000"> <tt>Thanks for
              verifying the fix, Sven.<br>
              <br>
              Mandy<br>
            </tt><br>
            <div class="m_-546807173986766857moz-cite-prefix">On
              10/25/18 10:09 AM, Sven Reimers wrote:<br>
            </div>
            <blockquote type="cite">
              <div dir="ltr">Hi,
                <div><br>
                </div>
                <div>jus tested the suggested fix against jdk12 head
                  with NetBeans 10VC1 and self sampling works as
                  expected.</div>
                <div><br>
                </div>
                <div>Thanks for your hard work.</div>
                <div><br>
                </div>
                <div>Sven</div>
                <br>
                <div class="gmail_quote">
                  <div dir="ltr">On Thu, Oct 25, 2018 at 8:52 AM Mandy
                    Chung <<a href="mailto:mandy.chung@oracle.com"
                      target="_blank" moz-do-not-send="true">mandy.chung@oracle.com</a>>
                    wrote:<br>
                  </div>
                  <blockquote class="gmail_quote" style="margin:0 0 0
                    .8ex;border-left:1px #ccc solid;padding-left:1ex">
                    <div bgcolor="#FFFFFF" text="#000000"> <br>
                      <br>
                      <div
class="m_-546807173986766857m_-8340227826582765852m_3250460842153846706moz-cite-prefix">On
                        10/25/18 2:52 AM, Daniel Fuchs wrote:<br>
                      </div>
                      <blockquote type="cite">Hi Mandy, <br>
                        <br>
                        I agree that this looks more robust and will be
                        better for <br>
                        long term maintainability. I'm just surprised
                        that <br>
                        <br>
                         156     static CompositeType compositeType() {
                        <br>
                         157         return
                        STACK_TRACE_ELEMENT_COMPOSITE_TYPE; <br>
                         158     } <br>
                        <br>
                        is no longer (or was never) needed in
                        StackTraceElementCompositeData <br>
                        when <br>
                        <br>
                         146     static CompositeType v5CompositeType()
                        { <br>
                         147         return V5_COMPOSITE_TYPE; <br>
                         148     } <br>
                        <br>
                        appears to still be needed. <br>
                        <br>
                      </blockquote>
                      <br>
                      It's used by MonitorInfoCompositeInfo and
                      ThreadInfoCompositeInfo to build their
                      CompositeType of older version.  For the current
                      version, it gets it from
                      MappedMXBeanType.toOpenType and hence no need for
                      compositeType().<br>
                      <br>
                      <blockquote type="cite">Otherwise, this looks good
                        to me. <br>
                      </blockquote>
                      <br>
                      Thanks for the review.<br>
                      <br>
                      Mandy<br>
                      <br>
                      <blockquote type="cite"> <br>
                        best regards, <br>
                        <br>
                        -- daniel <br>
                        <br>
                        On 24/10/2018 23:53, Mandy Chung wrote: <br>
                        <blockquote type="cite">This patch fixes the
                          regression introduced by JDK-8198253 in 11. <br>
                          It turns out that NetBeans uses the internal
                          sun.management API to <br>
                          convert ThreadInfo to CompositeData for
                          performance reason. <br>
                          ThreadInfoCompositeData::toCompositeData is no
                          longer used <br>
                          in JDK since JMX added the MXBean support in
                          JDK 6. The fix for <br>
                          JDK-8212197 resolves one issue reported [1]
                          but not the bug in <br>
                          ThreadInfoCompositeData::toCompositeData. Sven
                          has filed an <br>
                          issue in NetBeans to replace the use of JDK
                          internal API. <br>
                          <br>
                          Webrev: <br>
                          <a
class="m_-546807173986766857m_-8340227826582765852m_3250460842153846706moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Emchung/jdk12/webrevs/8212795/webrev.00/"
                            target="_blank" moz-do-not-send="true">http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8212795/webrev.00/</a>
                          <br>
                          <br>
                          Thanks <br>
                          Mandy <br>
                          [1] <a
class="m_-546807173986766857m_-8340227826582765852m_3250460842153846706moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025512.html"
                            target="_blank" moz-do-not-send="true">http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-October/025512.html</a><br>
                          [2] <a
class="m_-546807173986766857m_-8340227826582765852m_3250460842153846706moz-txt-link-freetext"
href="https://issues.apache.org/jira/browse/NETBEANS-1478"
                            target="_blank" moz-do-not-send="true">https://issues.apache.org/jira/browse/NETBEANS-1478</a>
                          <br>
                        </blockquote>
                        <br>
                      </blockquote>
                      <br>
                    </div>
                  </blockquote>
                </div>
                <br clear="all">
                <div><br>
                </div>
                -- <br>
                <div dir="ltr"
                  class="m_-546807173986766857m_-8340227826582765852gmail_signature"
                  data-smartmail="gmail_signature">
                  <div dir="ltr">
                    <div>
                      <div dir="ltr">
                        <div dir="ltr">
                          <div>Sven Reimers<br>
                            <br>
                            * Senior Expert Software Architect</div>
                          <div>* Java Champion<br>
                            * NetBeans Dream Team Member: <a
                              href="http://dreamteam.netbeans.org"
                              target="_blank" moz-do-not-send="true">http://dreamteam.netbeans.org</a><br>
                            * Community Leader  NetBeans: <a
                              href="http://community.java.net/netbeans"
                              target="_blank" moz-do-not-send="true">http://community.java.net/netbeans</a><br>
                                                          Desktop Java:
                            <a
                              href="http://community.java.net/javadesktop"
                              target="_blank" moz-do-not-send="true">http://community.java.net/javadesktop</a><br>
                          </div>
                          * JUG Leader JUG Bodensee: <a
                            href="http://www.jug-bodensee.de"
                            target="_blank" moz-do-not-send="true">http://www.jug-bodensee.de</a><br>
                          <div>* Duke's Choice Award Winner 2009<br>
                            <br>
                            * XING: <a
                              href="https://www.xing.com/profile/Sven_Reimers8"
                              target="_blank" moz-do-not-send="true">https://www.xing.com/profile/Sven_Reimers8</a><br>
                            * LinkedIn: <a
                              href="http://www.linkedin.com/in/svenreimers"
                              target="_blank" moz-do-not-send="true">http://www.linkedin.com/in/svenreimers</a><br>
                          </div>
                        </div>
                      </div>
                    </div>
                  </div>
                </div>
              </div>
            </blockquote>
            <br>
          </div>
        </blockquote>
      </div>
      <br clear="all">
      <div><br>
      </div>
      -- <br>
      <div dir="ltr" class="gmail_signature"
        data-smartmail="gmail_signature">
        <div dir="ltr">
          <div>
            <div dir="ltr">
              <div dir="ltr">
                <div>Sven Reimers<br>
                  <br>
                  * Senior Expert Software Architect</div>
                <div>* Java Champion<br>
                  * NetBeans Dream Team Member: <a
                    href="http://dreamteam.netbeans.org" target="_blank"
                    moz-do-not-send="true">http://dreamteam.netbeans.org</a><br>
                  * Community Leader  NetBeans: <a
                    href="http://community.java.net/netbeans"
                    target="_blank" moz-do-not-send="true">http://community.java.net/netbeans</a><br>
                                                Desktop Java: <a
                    href="http://community.java.net/javadesktop"
                    target="_blank" moz-do-not-send="true">http://community.java.net/javadesktop</a><br>
                </div>
                * JUG Leader JUG Bodensee: <a
                  href="http://www.jug-bodensee.de" target="_blank"
                  moz-do-not-send="true">http://www.jug-bodensee.de</a><br>
                <div>* Duke's Choice Award Winner 2009<br>
                  <br>
                  * XING: <a
                    href="https://www.xing.com/profile/Sven_Reimers8"
                    target="_blank" moz-do-not-send="true">https://www.xing.com/profile/Sven_Reimers8</a><br>
                  * LinkedIn: <a
                    href="http://www.linkedin.com/in/svenreimers"
                    target="_blank" moz-do-not-send="true">http://www.linkedin.com/in/svenreimers</a><br>
                </div>
              </div>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>