<div dir="ltr">Thanks Serguei, I fixed that in my local version, could I get a second review from someone?<br><div><br></div><div>Thanks,</div><div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Nov 10, 2018 at 3:24 PM <a href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> <<a href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_-6281251377690293445moz-cite-prefix">Hi Jc,<br>
<br>
Looks good.<br>
<br>
One minor comment.<br>
<br>
<a class="m_-6281251377690293445moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Ejcbeyler/8212931/webrev.00/test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java.frames.html" target="_blank">http://cr.openjdk.java.net/%7Ejcbeyler/8212931/webrev.00/test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitor.java.frames.html</a><br>
<br>
 The "average" in comments is not needed anymore:<br>
<pre> 112 // Calculate the size of a 1-element array in order to assess average sampling interval
<span class="m_-6281251377690293445changed"> 113 // via the HeapMonitorStatIntervalTest.</span>
...
</pre>
<pre> 125 // Get the actual average size.
<span class="m_-6281251377690293445changed"> 126 oneElementSize = getSize(frames);</span>
<span class="m_-6281251377690293445changed"> 127 System.out.println("Element size is: " + oneElementSize);</span></pre>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 11/9/18 19:42, JC Beyler wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi all,<br>
<div><br>
</div>
<div>Any chance I can get a review on this (technically two
reviews :-))?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Jc</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Fri, Nov 2, 2018 at 3:55 PM JC Beyler <<a href="mailto:jcbeyler@google.com" target="_blank">jcbeyler@google.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>Could I get a review for a bug in the calculation
of the average size of an allocation? The solution is
actually not to do the calculation at all. Instead, I
just go in the cache and find an object with the right
stacktrace and get its size (since all sizes should be
equal because they are allocating every time 1-element
arrays).</div>
<div><br>
</div>
<div>This removes the risk of a problem and simplifies
the test.<br>
<div><br>
</div>
Webrev:Â <a href="http://cr.openjdk.java.net/%7Ejcbeyler/8212931/webrev.00/" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8212931/webrev.00/</a></div>
<div>Bug:Â <a href="https://bugs.openjdk.java.net/browse/JDK-8212931?filter=-1" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8212931?filter=-1</a><br>
<div dir="ltr" class="m_-6281251377690293445m_2535327701763435043gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
<div><br>
</div>
-- <br>
<div dir="ltr" class="m_-6281251377690293445gmail_signature" data-smartmail="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>