RFR: Force unix line endings when writing patch files
Jorn Vernee via github.com
duke at openjdk.java.net
Thu Aug 22 15:15:29 UTC 2019
On Thu, 22 Aug 2019 15:13:34 GMT, Erik Duveblad via github.com <duke at openjdk.java.net> wrote:
> On Thu, 22 Aug 2019 15:07:04 GMT, Jorn Vernee via github.com <duke at openjdk.java.net> wrote:
>> Mercurial needs its patch files to end with unix line endings, so we need to use those explicitly when writing patch files (I've also been told on the hg irc that this is according to patch file spec).
>> - c1f1dda5: Force unix line endings when writing patch files
>> Pull request:
>> Fetch command:
>> git fetch https://git.openjdk.java.net/skara pull/71/head:pull/71
> Hi Jorn,
> thanks for fixing this! If this patch fixes some tests to pass on Windows, which tests are now passing that didn't before this patch?
> PR: https://git.openjdk.java.net/skara/pull/71
@edvbld Particularly; `GitToHgConverterTests::convertMergeCommitWithP0Diff` and `GitToHgConverterTests::convertMergeCommit`, which both failed while applying the patch.
More information about the skara-dev