RFR: Avoid using getUrl when creating folder names
Erik Duveblad via github.com
duke at openjdk.java.net
Fri Aug 23 09:37:42 UTC 2019
On Fri, 23 Aug 2019 09:37:40 GMT, Robin Westberg via github.com <duke at openjdk.java.net> wrote:
> Hi all,
> Please review this change that replaces calls to getUrl with getWebUrl when creating names of folders to clone repositories into. The problem is that getUrl can contain credentials, which getWebUrl does not.
> Best regards,
> - 53ede458: Avoid using getUrl when creating folder names, as it may contain credentials
> Pull request:
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/77/head:pull/77
This PR has been reviewed by Erik Duveblad via github.com - changes are approved. Review comment:
Looks good, great fix!
More information about the skara-dev