RFR: 88: git token store https://github.com does not work
Jorn Vernee via github.com
duke at openjdk.java.net
Thu Aug 29 10:15:58 UTC 2019
On Thu, 29 Aug 2019 09:32:27 GMT, Stefan Johansson via github.com <duke at openjdk.java.net> wrote:
> Please review this fix to avoid getting exceptions when having URIs with empty paths. Instead of assuming a leading '/' we now check the path in GitCredentials.fill and only removes a leading '/' if it is present.
> Basic tests pass, but the affected commands have not yet been tested thoroughly.
> - 8903663b: 88: git token store https://github.com does not work
> Pull request:
> Fetch command:
> git fetch https://git.openjdk.java.net/skara pull/103/head:pull/103
This PR has been reviewed by Jorn Vernee via github.com - changes are approved. Review comment:
@kstefanj thanks for fixing this! Change looks good.
More information about the skara-dev