RFR: Ensure Python 3 compatibility for the hg extension
ehelin at openjdk.java.net
Tue Nov 26 07:16:25 UTC 2019
On Tue, 26 Nov 2019 06:38:06 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> On Mon, 25 Nov 2019 13:28:47 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>> On Mon, 25 Nov 2019 11:09:15 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>>> On Mon, 25 Nov 2019 09:06:33 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>>>> Hi all,
>>>> Please review this change that makes Skara's internally used Mercurial extension work with Python 3, while also retaining Python 2 compatibility. The Mercurial distribution on MacOS (through homebrew) recently switched to using Python 3, so this change will make the CI for Mac pass again.
>>>> Best regards,
>>>> - 27aef11c: Refactor usages of .encode
>>>> - 85287fe7: Restore python2 compatibility
>>>> - dd54ede1: More adjustments
>>>> - f90befc2: Mercurial wants byte strings when using 3
>>>> Changes: https://git.openjdk.java.net/skara/pull/267/files
>>>> Webrev: https://webrevs.openjdk.java.net/skara/267/webrev.00
>>>> Stats: 57 lines in 1 file changed: 7 ins; 3 del; 47 mod
>>>> Patch: https://git.openjdk.java.net/skara/pull/267.diff
>>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/267/head:pull/267
>>> Robin what kind of testing have you done on this change? Could you please try to do a fresh conversion of one the smaller repositories, like jtreg, to ensure that we haven't broken anything? The unit tests exercise the Mercurial extension quite a bit, but I really want to ensure we don't mess anything up with regards to the hg -> git conversion.
>> The jtreg repository is actually partially converted in the hgbridge tests, but yes, it makes sense to do something a little more extensive.. I'll kick off a few bigger conversions.
> Converted the jdk and panama repositories, and they ended up with the same commit hashes, so I think it's looking good. This was using using Mercurial with Python 2, but we can probably keep using that for the conversions.
Ok, great! Yeah, I agree we can keep using Mercurial with Python 2 for the conversion.
More information about the skara-dev