[Approved] RFR: Initial version of issue updater
ehelin at openjdk.java.net
Wed Nov 27 10:22:09 UTC 2019
On Wed, 27 Nov 2019 09:20:07 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
> Hi all,
> Please review this change that adds the first version of an issue updater (similar to what hgupdater currently provides for mercurial repositories).
> Best regards,
> - ebed0696: Initial version of issue updater
> Changes: https://git.openjdk.java.net/skara/pull/273/files
> Webrev: https://webrevs.openjdk.java.net/skara/273/webrev.00
> Stats: 241 lines in 5 files changed: 192 ins; 45 del; 4 mod
> Patch: https://git.openjdk.java.net/skara/pull/273.diff
> Fetch: git fetch https://git.openjdk.java.net/skara pull/273/head:pull/273
Very nice work Robin! So nice to see all the pieces fit into place
I would probably have dropped the `commit` prefix from `CommitFormatters.commitToText` and `CommitFormatters.commitToTextBrief`, so that the methods instead read `CommitFormatters.toText` and `CommitFormatters.toTextBrief`. Since they are `static` it is clear at the call sites that a commit is being formatted.
Approved by ehelin (Reviewer).
More information about the skara-dev