RFR: WIP: 108: Command line tools fon't run with Cygwin git
ehelin at openjdk.org
Fri Oct 4 07:55:12 UTC 2019
On Wed, 2 Oct 2019 12:24:00 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:
> On Wed, 2 Oct 2019 09:42:50 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>> On Mon, 30 Sep 2019 21:28:59 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>>> This is a very preliminary "proof of concept" patch that allows `git jcheck` to work with git from Cygwin. It is incomplete, and is missing the necessary checks to allow it to continue working with native Windows git.
>>> @edvbld @rwestberg - I submitted it this early to get your high-level feedback on whether this support is something that you have already thought about already; if not, I'd like your feedback on the approach.
>>> The idea would be to check whether we are are using a Cygwin version of git (this should be trivial), and if so, do the conversion between the `Path` strings and the input/output to the `git` command in all of the necessary places in `GitRepository` (that should be the only class that needs to be modified).
>>> - 11270d33: WIP: 108: Command line tools fon't run with Cygwin git
>>> Changes: https://git.openjdk.java.net/skara/pull/170/files
>>> Webrev: https://webrevs.openjdk.java.net/skara/170/webrev.00
>>> Stats: 30 lines in 2 files changed: 23 ins; 0 del; 7 mod
>>> Patch: https://git.openjdk.java.net/skara/pull/170.diff
>>> Fetch: git fetch https://git.openjdk.java.net/skara pull/170/head:pull/170
>> Looks like a reasonable approach to me, perhaps our most prominent Windows user @jornvernee has considered something in this area.. I usually avoid installing cygwin git to avoid issues like this.
> @rwestberg I'm happily using Windows native git :)
thanks for looking into this and sorry for not responding earlier. I would like to understand your use case a bit more - why are you using Cygwin git over [Git for Windows](https://gitforwindows.org/)? I understand that you need to use Cygwin, but why not use the Windows native git binary in Cygwin (instead of Cygwin's version of git)?
Looking at your changes I can immediately see that adding support for the Cygwin version of git will have far-reaching consequences for almost all our code, so I would really like to understand the advantages of using Cygwin git before pursuing this further.
More information about the skara-dev