[Approved] RFR: Fix the HunkCoalescer again
rwestberg at openjdk.org
Fri Oct 18 12:52:59 UTC 2019
On Fri, 18 Oct 2019 12:41:38 GMT, Erik Helin <ehelin at openjdk.org> wrote:
> Hi all,
> seems like the `HunkCoalescer` wasn't finished with me just yet. I forgot about some end-of-file use cases and also applied my previous fix in the wrong place. This time however it works, many thanks to @JornVernee for testing and reporting the additional bugs.
> - c0c399ca: Fix the HunkCoalescer again
> Changes: https://git.openjdk.java.net/skara/pull/214/files
> Webrev: https://webrevs.openjdk.java.net/skara/214/webrev.00
> Stats: 12 lines in 1 file changed: 6 ins; 6 del; 0 mod
> Patch: https://git.openjdk.java.net/skara/pull/214.diff
> Fetch: git fetch https://git.openjdk.java.net/skara pull/214/head:pull/214
Very well, but I still think there should be a test or two for this. :)
Approved by rwestberg (Reviewer).
More information about the skara-dev