RFR: update-sync labels should be applied to all-bar-one records
rwestberg at openjdk.java.net
Wed Sep 30 10:53:06 UTC 2020
On Tue, 29 Sep 2020 12:39:00 GMT, Rob McKenna <robm at openjdk.org> wrote:
>> The fix looks good to me. One question about the test: is the `assertNotLabeled` method really needed? It looks like
>> `assertLabeled` will fail unless the set of issues with the labels is exactly as expected (i.e., it will fail if it
>> finds an issue that should have the sync label but doesn't or if if find an issue that should not have the sync label
>> but does), unless I'm missing something.
> I think I like the lack of ambiguity in the name. I vote to leave it in, but if Robin objects I can remove it.
I don't mind keeping it if you think it makes the test more readable!
More information about the skara-dev