<Swing Dev> [PATCH] 6179357: Generics: JList
Alexander.Potochkin at Sun.COM
Tue Apr 14 08:46:59 PDT 2009
> Great! :-)
> In the case of other issues please note that I'm on holiday until the
> end of next week.
Have a nice holiday!
(I am reviewing the fix right now)
> Pavel Porvatov schrieb:
>> Hi Florian,
>>> Hi Pavel,
>>> I agree that we should avoid to mix several different fixes in one
>>> fix, but since in this fix we change
>>> AbstractListModel to AbstractListModel<E>
>>> JList(ListModel dataModel) to JList(ListModel<E> dataModel)
>>> I think we should also change usages of AbstractListModel such as
>>> "this (new AbstractListModel()...)" to "this (new
>>> AbstractListModel<E>()...)" to avoid warnings.
>> Ok, then it will not be a problem. Let's include this change in your
>> fix. Therefore all my comments are gone and I'm going to start our
>> internal process to commit your fix.
>> Thanks, Pavel.
>>> If you don't agree:
>>> There are several places where I changed the usage of now generified
>>> classes to the generic variant. Which ones should I change back? Only
>>> this case?
More information about the swing-dev