From pavel.porvatov at sun.com  Fri Nov  6 01:53:54 2009
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Fri, 06 Nov 2009 09:53:54 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6621569: Win32ShellFolder2
	and	Win32ShellFolderManager2 may leak native resources
Message-ID: <20091106095438.2B8B94173D@hg.openjdk.java.net>

Changeset: 18ef20250e99
Author:    rupashka
Date:      2009-11-06 12:44 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/18ef20250e99

6621569: Win32ShellFolder2 and Win32ShellFolderManager2 may leak native resources
Reviewed-by: malenkov

! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java
! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java


From alexander.potochkin at sun.com  Fri Nov  6 11:34:50 2009
From: alexander.potochkin at sun.com (alexander.potochkin at sun.com)
Date: Fri, 06 Nov 2009 19:34:50 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 2 new changesets
Message-ID: <20091106193533.5FCDC417E5@hg.openjdk.java.net>

Changeset: ce83706b9c86
Author:    alexp
Date:      2009-11-06 22:26 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/ce83706b9c86

6879228: LayerUI should be extended
Reviewed-by: peterz

! src/share/classes/javax/swing/plaf/LayerUI.java

Changeset: 7770a96da080
Author:    alexp
Date:      2009-11-06 22:33 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/7770a96da080

Merge



From alexander.potochkin at sun.com  Fri Nov  6 11:41:41 2009
From: alexander.potochkin at sun.com (alexander.potochkin at sun.com)
Date: Fri, 06 Nov 2009 19:41:41 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6878399:
	public	SwingUtilities.getParentViewport() is required
Message-ID: <20091106194157.72FA3417E9@hg.openjdk.java.net>

Changeset: 38181ef722ec
Author:    alexp
Date:      2009-11-06 22:40 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/38181ef722ec

6878399: public SwingUtilities.getParentViewport() is required
Reviewed-by: peterz

! src/share/classes/javax/swing/JEditorPane.java
! src/share/classes/javax/swing/JList.java
! src/share/classes/javax/swing/JTable.java
! src/share/classes/javax/swing/JTextField.java
! src/share/classes/javax/swing/JTree.java
! src/share/classes/javax/swing/SwingUtilities.java
! src/share/classes/javax/swing/text/JTextComponent.java
! src/share/classes/sun/swing/SwingUtilities2.java


From c.cerbo at gmail.com  Fri Nov  6 17:42:19 2009
From: c.cerbo at gmail.com (Costantino Cerbo)
Date: Sat, 7 Nov 2009 02:42:19 +0100
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
	match native GTK 2.4 widget
Message-ID: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>

Hello,

To implement the new GTK file chooser I've started this open source project:
http://code.google.com/p/gtkjfilechooser/

I've just released the first beta version tested on Fedora 10 and
Ubuntu 9.04 and I'd like to integrate it in the JDK: how do we do
that?

You can already run a full working demo, download the .zip for the
last version, unpack it and run
  $ java -jar gtkjfilechooser-demo.jar

Other useful infos are in the wiki pages.

I'm looking forward to hearing your feedback
Best Regards,
Costantino - Stuttgart, Germany

From Pavel.Porvatov at Sun.COM  Mon Nov  9 02:18:45 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Mon, 09 Nov 2009 13:18:45 +0300
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
 match native GTK 2.4 widget
In-Reply-To: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
Message-ID: <4AF7EC85.2090303@sun.com>

Hi Costantino,

I've tried to run the demo but I got the next exception:
java -jar gtkjfilechooser-demo.jar
Exception in thread "main" java.io.IOError: 
java.io.FileNotFoundException: Cannot find resource null
        at 
eu.kostia.gtkjfilechooser.GettextResource.<init>(GettextResource.java:187)
        at eu.kostia.gtkjfilechooser.I18N.<clinit>(I18N.java:45)
        at 
eu.kostia.gtkjfilechooser.ui.GtkFileChooserUI.installStrings(GtkFileChooserUI.java:752)
        at 
javax.swing.plaf.basic.BasicFileChooserUI.installDefaults(BasicFileChooserUI.java:241)
        at 
javax.swing.plaf.basic.BasicFileChooserUI.installUI(BasicFileChooserUI.java:156)
        at javax.swing.JComponent.setUI(JComponent.java:664)
        at javax.swing.JFileChooser.updateUI(JFileChooser.java:1787)
        at javax.swing.JFileChooser.setup(JFileChooser.java:374)
        at javax.swing.JFileChooser.<init>(JFileChooser.java:347)
        at javax.swing.JFileChooser.<init>(JFileChooser.java:300)
        at 
eu.kostia.gtkjfilechooser.demo.FileChooserDemo.<init>(FileChooserDemo.java:135)
        at 
eu.kostia.gtkjfilechooser.demo.FileChooserDemo.main(FileChooserDemo.java:638)
Caused by: java.io.FileNotFoundException: Cannot find resource null
        ... 12 more

Regards, Pavel
> Hello,
>
> To implement the new GTK file chooser I've started this open source project:
> http://code.google.com/p/gtkjfilechooser/
>
> I've just released the first beta version tested on Fedora 10 and
> Ubuntu 9.04 and I'd like to integrate it in the JDK: how do we do
> that?
>
> You can already run a full working demo, download the .zip for the
> last version, unpack it and run
>   $ java -jar gtkjfilechooser-demo.jar
>
> Other useful infos are in the wiki pages.
>
> I'm looking forward to hearing your feedback
> Best Regards,
> Costantino - Stuttgart, Germany
>   


From c.cerbo at gmail.com  Mon Nov  9 03:36:05 2009
From: c.cerbo at gmail.com (Costantino Cerbo)
Date: Mon, 9 Nov 2009 12:36:05 +0100
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
	match native GTK 2.4 widget
In-Reply-To: <4AF7EC85.2090303@sun.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
	<4AF7EC85.2090303@sun.com>
Message-ID: <6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>

Hello Pavel,

Could you try with this updated version:
  http://gtkjfilechooser.googlecode.com/files/GtkJFileChooser_v1.3.1.zip

The reason for this exception is that I'use the native gtk bundles for the I18N.
For example under Fedora it is in
  /usr/share/locale/it/LC_MESSAGES/gtk20.mo
But under Ubuntu and Suse respectively in /usr/share/locale-langpack
and /usr/share/locale-bundle

What OS do you use? and where is your gtk20.mo?

I know, that isn't the standay way the I18N is done in Swing, but for
the moment I wanted to "recycle" the gnome bundles.
For the next releases we can adopt the standard Swing way.

Let me know if now it works correctly.
Bye,
Costantino

P.S.: The error was here:
http://code.google.com/p/gtkjfilechooser/source/browse/branches/release_1_3/GtkJFileChooser/src/eu/kostia/gtkjfilechooser/I18N.java
I've also writtern a wiki page about gettext:
http://code.google.com/p/gtkjfilechooser/wiki/GettextResource




2009/11/9 Pavel Porvatov <Pavel.Porvatov at sun.com>:
> Hi Costantino,
>
> I've tried to run the demo but I got the next exception:
> java -jar gtkjfilechooser-demo.jar
> Exception in thread "main" java.io.IOError: java.io.FileNotFoundException:
> Cannot find resource null
> ? ? ? at
> eu.kostia.gtkjfilechooser.GettextResource.<init>(GettextResource.java:187)
> ? ? ? at eu.kostia.gtkjfilechooser.I18N.<clinit>(I18N.java:45)
> ? ? ? at
> eu.kostia.gtkjfilechooser.ui.GtkFileChooserUI.installStrings(GtkFileChooserUI.java:752)
> ? ? ? at
> javax.swing.plaf.basic.BasicFileChooserUI.installDefaults(BasicFileChooserUI.java:241)
> ? ? ? at
> javax.swing.plaf.basic.BasicFileChooserUI.installUI(BasicFileChooserUI.java:156)
> ? ? ? at javax.swing.JComponent.setUI(JComponent.java:664)
> ? ? ? at javax.swing.JFileChooser.updateUI(JFileChooser.java:1787)
> ? ? ? at javax.swing.JFileChooser.setup(JFileChooser.java:374)
> ? ? ? at javax.swing.JFileChooser.<init>(JFileChooser.java:347)
> ? ? ? at javax.swing.JFileChooser.<init>(JFileChooser.java:300)
> ? ? ? at
> eu.kostia.gtkjfilechooser.demo.FileChooserDemo.<init>(FileChooserDemo.java:135)
> ? ? ? at
> eu.kostia.gtkjfilechooser.demo.FileChooserDemo.main(FileChooserDemo.java:638)
> Caused by: java.io.FileNotFoundException: Cannot find resource null
> ? ? ? ... 12 more
>
> Regards, Pavel
>>
>> Hello,
>>
>> To implement the new GTK file chooser I've started this open source
>> project:
>> http://code.google.com/p/gtkjfilechooser/
>>
>> I've just released the first beta version tested on Fedora 10 and
>> Ubuntu 9.04 and I'd like to integrate it in the JDK: how do we do
>> that?
>>
>> You can already run a full working demo, download the .zip for the
>> last version, unpack it and run
>> ?$ java -jar gtkjfilechooser-demo.jar
>>
>> Other useful infos are in the wiki pages.
>>
>> I'm looking forward to hearing your feedback
>> Best Regards,
>> Costantino - Stuttgart, Germany
>>
>
>

From yuka.kamiya at sun.com  Tue Nov 10 23:48:14 2009
From: yuka.kamiya at sun.com (yuka.kamiya at sun.com)
Date: Wed, 11 Nov 2009 07:48:14 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6899397: (tz) Support tzdata2009r
Message-ID: <20091111074843.BDE8141EFF@hg.openjdk.java.net>

Changeset: fef334c21d6c
Author:    peytoia
Date:      2009-11-11 15:38 +0900
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/fef334c21d6c

6899397: (tz) Support tzdata2009r
Reviewed-by: okutsu

! make/sun/javazic/tzdata/VERSION
! make/sun/javazic/tzdata/antarctica
! make/sun/javazic/tzdata/asia
! make/sun/javazic/tzdata/australasia
! make/sun/javazic/tzdata/europe
! make/sun/javazic/tzdata/southamerica
! make/sun/javazic/tzdata/zone.tab
! src/share/classes/sun/util/resources/TimeZoneNames.java
! src/share/classes/sun/util/resources/TimeZoneNames_de.java
! src/share/classes/sun/util/resources/TimeZoneNames_es.java
! src/share/classes/sun/util/resources/TimeZoneNames_fr.java
! src/share/classes/sun/util/resources/TimeZoneNames_it.java
! src/share/classes/sun/util/resources/TimeZoneNames_ja.java
! src/share/classes/sun/util/resources/TimeZoneNames_ko.java
! src/share/classes/sun/util/resources/TimeZoneNames_sv.java
! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java
! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java


From fbrunnerlist at gmx.ch  Wed Nov 11 14:29:58 2009
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Wed, 11 Nov 2009 23:29:58 +0100
Subject: <Swing Dev> [PATCH] 6179357: Generics: JList
In-Reply-To: <4AC0E891.2090307@sun.com>
References: <200903222003.05081.fbrunnerlist@gmx.ch>
	<200909280120.03003.fbrunnerlist@gmx.ch> <4AC0E891.2090307@sun.com>
Message-ID: <200911112329.58520.fbrunnerlist@gmx.ch>

Hi Pavel,

just my monthly status request: any news?

-Florian

Am Montag, 28. September 2009 schrieb Pavel Porvatov:
> Hi Florian,
>
> > Hi Pavel,
> >
> > did you have time to look at the patch already? What's the status?
>
> Yes, I combined your tests into one and it works. Unfortunately the fix
> will be delayed because internal approve of the fix is not finished yet
> (I was wrong when I wrote about approve completion, sorry)... I'll let
> you know when I commit your fix.
>
> Regards, Pavel
>
> > -Florian
> >
> > Am Montag, 14. September 2009 schrieb Pavel Porvatov:
> >> Hi Florian,
> >>
> >> Thanks! I will continue work with your fix tomorrow.
> >>
> >>> Hi Pavel,
> >>>
> >>> here are some jtreg tests, which test the signatures of the changed API
> >>> (raw & generic calls).
> >>>
> >>> Note that, of course, the generic tests won't even compile before the
> >>> generic JList patch is applied. So, if you care, you could:
> >>> - remove the generic tests (should be simple)
> >>> - run the test with the unpatched version
> >>> - check them in
> >>> - upgrade the test along with the JList patch
> >>> - run them again
> >>> - check them both in
> >>>
> >>> Please also  check the license header and the test annotations.
> >>
> >> Ok, I'll do it.
> >>
> >> Regards, Pavel.
> >>
> >>> -Florian
> >>>
> >>> Am Donnerstag, 3. September 2009 schrieb Florian Brunner:
> >>>> Hi Pavel,
> >>>>
> >>>> great news! :-)
> >>>>
> >>>> I will have a look at jtreg.
> >>>>
> >>>> -Florian
> >>>>
> >>>> Pavel Porvatov schrieb:
> >>>>> Hi Florian,
> >>>>>
> >>>>>> any news about my patch? What is the status? I understand that
> >>>>>> approving of the API is not a quick step, but then it's already 2-3
> >>>>>> months. And we need to do the same for all the other planed API-
> >>>>>> changes to "generify" Swing. It would be great if we could speed
> >>>>>> things up a bit again.
> >>>>>
> >>>>> The good news: the patch was approved on last Friday! So I can push
> >>>>> it. But many people asked about regression tests. Could you please
> >>>>> write such automatic tests for the fix. E.g.
> >>>>>
> >>>>> -----
> >>>>>         String[] strings = new String[] {"A string"};
> >>>>>
> >>>>>         new JList(strings);
> >>>>>
> >>>>>         Vector v1 = new Vector();
> >>>>>
> >>>>>         new JList(v1);
> >>>>>
> >>>>>         Vector<String> v2 = new Vector<String>();
> >>>>>
> >>>>>         new JList(v2);
> >>>>> -----
> >>>>> etc.
> >>>>>
> >>>>> Here you can find some info about test framework:
> >>>>> http://openjdk.java.net/jtreg/
> >>>>>
> >>>>> Thanks, Pavel.
> >>>>>
> >>>>>> What do you estimate, how much more time this step takes?
> >>>>>>
> >>>>>> Thanks.
> >>>>>> -Florian
> >>>>>>
> >>>>>> Am Mittwoch, 22. Juli 2009 schrieben Sie:
> >>>>>>> Hi Florian,
> >>>>>>>
> >>>>>>>> Hi Pavel,
> >>>>>>>>
> >>>>>>>> I hope you had nice holidays.
> >>>>>>>>
> >>>>>>>> Do you have any news about the patch?
> >>>>>>>
> >>>>>>> I'm awaiting approve of API changes. It's not a very quick step
> >>>>>>> because a lot of people should take a look at your changes and give
> >>>>>>> approve for it...
> >>>>>>>
> >>>>>>> Regards, Pavel
> >>>>>>>
> >>>>>>>> -Florian
> >>>>>>>>
> >>>>>>>> Am Freitag, 19. Juni 2009 schrieb Florian Brunner:
> >>>>>>>>> Hi Pavel,
> >>>>>>>>>
> >>>>>>>>> enjoy your holidays! My holidays start from 27th June till 8th
> >>>>>>>>> July, so
> >>>>>>>>> we can continue the work on generics afterwards again.
> >>>>>>>>>
> >>>>>>>>> -Florian
> >>>>>>>>>
> >>>>>>>>> Am Donnerstag, 11. Juni 2009 schrieb Pavel Porvatov:



From yuka.kamiya at sun.com  Thu Nov 12 02:23:27 2009
From: yuka.kamiya at sun.com (yuka.kamiya at sun.com)
Date: Thu, 12 Nov 2009 10:23:27 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6842557: NumericShaper needs to be
	updated for	Unicode 5.1 support; ...
Message-ID: <20091112102428.1510041451@hg.openjdk.java.net>

Changeset: 62142df88a07
Author:    peytoia
Date:      2009-11-12 18:59 +0900
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/62142df88a07

6842557: NumericShaper needs to be updated for Unicode 5.1 support
6843181: NumericShaper is not thread-safe
6900137: Typo in API Doc for NumericShaper
Reviewed-by: okutsu

! src/share/classes/java/awt/font/NumericShaper.java
+ test/java/awt/font/NumericShaper/EqualsTest.java
+ test/java/awt/font/NumericShaper/MTTest.java
+ test/java/awt/font/NumericShaper/ShapingTest.java


From Pavel.Porvatov at Sun.COM  Thu Nov 12 03:01:52 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Thu, 12 Nov 2009 14:01:52 +0300
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
 match native GTK 2.4 widget
In-Reply-To: <6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
	<4AF7EC85.2090303@sun.com>
	<6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>
Message-ID: <4AFBEB20.6030601@sun.com>

Hi Costantino,

I run the demo and it looks good. Please take a look at my comments:
1. Gaps between components differ from the original FileChooser
2. Some bitmaps differ from the original FileChooser
3. I got some errors (see attach)

Regards, Pavel.

> Hello Pavel,
>
> Could you try with this updated version:
>   http://gtkjfilechooser.googlecode.com/files/GtkJFileChooser_v1.3.1.zip
>
> The reason for this exception is that I'use the native gtk bundles for the I18N.
> For example under Fedora it is in
>   /usr/share/locale/it/LC_MESSAGES/gtk20.mo
> But under Ubuntu and Suse respectively in /usr/share/locale-langpack
> and /usr/share/locale-bundle
>
> What OS do you use? and where is your gtk20.mo?
>
> I know, that isn't the standay way the I18N is done in Swing, but for
> the moment I wanted to "recycle" the gnome bundles.
> For the next releases we can adopt the standard Swing way.
>
> Let me know if now it works correctly.
> Bye,
> Costantino
>
> P.S.: The error was here:
> http://code.google.com/p/gtkjfilechooser/source/browse/branches/release_1_3/GtkJFileChooser/src/eu/kostia/gtkjfilechooser/I18N.java
> I've also writtern a wiki page about gettext:
> http://code.google.com/p/gtkjfilechooser/wiki/GettextResource
>
>
>
>
> 2009/11/9 Pavel Porvatov <Pavel.Porvatov at sun.com>:
>   
>> Hi Costantino,
>>
>> I've tried to run the demo but I got the next exception:
>> java -jar gtkjfilechooser-demo.jar
>> Exception in thread "main" java.io.IOError: java.io.FileNotFoundException:
>> Cannot find resource null
>>       at
>> eu.kostia.gtkjfilechooser.GettextResource.<init>(GettextResource.java:187)
>>       at eu.kostia.gtkjfilechooser.I18N.<clinit>(I18N.java:45)
>>       at
>> eu.kostia.gtkjfilechooser.ui.GtkFileChooserUI.installStrings(GtkFileChooserUI.java:752)
>>       at
>> javax.swing.plaf.basic.BasicFileChooserUI.installDefaults(BasicFileChooserUI.java:241)
>>       at
>> javax.swing.plaf.basic.BasicFileChooserUI.installUI(BasicFileChooserUI.java:156)
>>       at javax.swing.JComponent.setUI(JComponent.java:664)
>>       at javax.swing.JFileChooser.updateUI(JFileChooser.java:1787)
>>       at javax.swing.JFileChooser.setup(JFileChooser.java:374)
>>       at javax.swing.JFileChooser.<init>(JFileChooser.java:347)
>>       at javax.swing.JFileChooser.<init>(JFileChooser.java:300)
>>       at
>> eu.kostia.gtkjfilechooser.demo.FileChooserDemo.<init>(FileChooserDemo.java:135)
>>       at
>> eu.kostia.gtkjfilechooser.demo.FileChooserDemo.main(FileChooserDemo.java:638)
>> Caused by: java.io.FileNotFoundException: Cannot find resource null
>>       ... 12 more
>>
>> Regards, Pavel
>>     
>>> Hello,
>>>
>>> To implement the new GTK file chooser I've started this open source
>>> project:
>>> http://code.google.com/p/gtkjfilechooser/
>>>
>>> I've just released the first beta version tested on Fedora 10 and
>>> Ubuntu 9.04 and I'd like to integrate it in the JDK: how do we do
>>> that?
>>>
>>> You can already run a full working demo, download the .zip for the
>>> last version, unpack it and run
>>>  $ java -jar gtkjfilechooser-demo.jar
>>>
>>> Other useful infos are in the wiki pages.
>>>
>>> I'm looking forward to hearing your feedback
>>> Best Regards,
>>> Costantino - Stuttgart, Germany
>>>
>>>       
>>     

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: error
Url: http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20091112/e55dd8ad/attachment-0001.ksh 

From c.cerbo at gmail.com  Thu Nov 12 13:21:27 2009
From: c.cerbo at gmail.com (Costantino Cerbo)
Date: Thu, 12 Nov 2009 22:21:27 +0100
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
	match native GTK 2.4 widget
In-Reply-To: <4AFBEB20.6030601@sun.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
	<4AF7EC85.2090303@sun.com>
	<6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>
	<4AFBEB20.6030601@sun.com>
Message-ID: <6fbbec30911121321l33c88209g702b4118c642a3e1@mail.gmail.com>

Hallo Pavel

2009/11/12 Pavel Porvatov <Pavel.Porvatov at sun.com>:
> I run the demo and it looks good.
Thanks! I hope we can improve it so much to include it in the OpenJDK.

> Please take a look at my comments:
> 1. Gaps between components differ from the original FileChooser
Maybe do you refer to the Save Dialog? In the Open Dialog they are
quite similar (see the attached screenshot)

> 2. Some bitmaps differ from the original FileChooser
Do you mean the small preview icons near the filename?
This thumbs are in the folder /home/c.cerbo/.thumbnails/normal and
their name is the md5 of the file uri, for example:
  file:///home/c.cerbo/Documenti/Effective_Java.pdf   -->
6e1c7944eac7bc932b2b56c6ac94960f
The bug was that the uri must be encoded according rfc2396 (see
http://www.ietf.org/rfc/rfc2396.txt) and I didn't so, for example
  file:///home/c.cerbo/Documenti/Ciao Belli.pdf  becames
file:///home/c.cerbo/Documenti/Ciao%20Belli.pdf

The new code looks so like (eu.kostia.gtkjfilechooser.GtkStockIcon):
	private static File lookForThumbs(File file) {
		String thumbsFolder = System.getProperty("user.home") + "/.thumbnails/normal";
		String md5 = md5(toFileuri(file));

		File thumn = new File(thumbsFolder + "/" + md5 + ".png");

		if (!thumn.exists()) {
			return null;
		}
		return thumn;
	}

	static String toFileuri(File file) {
		return file.toURI().toASCIIString().replace("file:", "file://");
	}

Regarding the other icons, I get them directly from the actual
implementation in the JDK:
	private static Icon getFromStock(String name, Size size) {
		try {
			Class<?> gtkStockIconClass =
Class.forName("com.sun.java.swing.plaf.gtk.GTKStyle$GTKStockIcon");
			Constructor<?> constructor =
gtkStockIconClass.getDeclaredConstructor(String.class, int.class);
			constructor.setAccessible(true);
			return (Icon) constructor.newInstance(name, size.ordinal());
		} catch (Exception ex) {
			return null;
		}
	}


> 3. I got some errors (see attach)
How do you caused these exceptions? I cannot reproduce them.
Do the folders '/home/fritz/Documents' and '/home/fritz/Music' really exist?
They are some of the so-called "well known" user directories:

$ cat ~/.config/user-dirs.dirs
XDG_DESKTOP_DIR="$HOME/Scrivania"
XDG_DOWNLOAD_DIR="$HOME/Download"
XDG_TEMPLATES_DIR="$HOME/Modelli"
XDG_PUBLICSHARE_DIR="$HOME/Pubblici"
XDG_DOCUMENTS_DIR="$HOME/Documenti"
XDG_MUSIC_DIR="$HOME/Musica"
XDG_PICTURES_DIR="$HOME/Immagini"
XDG_VIDEOS_DIR="$HOME/Video"

Maybe did you manually delete them, but they are still in your ~/.gtk-bookmarks?
Could you check please the content of that file?

Thanks for your support!

Cheers,
Costantino

P.S.: Is there somebody else that may help to further test and improve
the new GtkFileChooser? Now that Java is open source it can become a
more important player in the desktop linux. Furthermore Gnome is also
the standard desktop environment under the Sun OS (Solaris). It's
really a pity, that the GTKLookAndFeel hasn't yet an updated
FileChooser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot_Open.png
Type: image/png
Size: 118215 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20091112/9756bf02/attachment-0001.png 

From c.cerbo at gmail.com  Thu Nov 12 15:24:23 2009
From: c.cerbo at gmail.com (Costantino Cerbo)
Date: Fri, 13 Nov 2009 00:24:23 +0100
Subject: <Swing Dev> new bugfix release of GtkJFilechooser
Message-ID: <6fbbec30911121524h19f58fbfm335fe259d52324c2@mail.gmail.com>

Hello,

I've just relesead the version 1.3.2 of the new JFileChooser for the
GTK Look and Feel:
  http://gtkjfilechooser.googlecode.com/files/GtkJFileChooser_v1.3.2.zip

You can see the list of fixed issues on
http://code.google.com/p/gtkjfilechooser/issues/list?can=1&q=label%3AFixed-Version1.3.2

The Issue 42 (Some bitmaps differ from the original FileChooser) is
that one reported by Pavel.

Bye, bye,
Costantino

From Pavel.Porvatov at Sun.COM  Thu Nov 12 23:17:21 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Fri, 13 Nov 2009 10:17:21 +0300
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
 match native GTK 2.4 widget
In-Reply-To: <6fbbec30911121321l33c88209g702b4118c642a3e1@mail.gmail.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
	<4AF7EC85.2090303@sun.com>
	<6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>
	<4AFBEB20.6030601@sun.com>
	<6fbbec30911121321l33c88209g702b4118c642a3e1@mail.gmail.com>
Message-ID: <4AFD0801.5030202@sun.com>

Hi Costantino,
> Hallo Pavel
>
> 2009/11/12 Pavel Porvatov <Pavel.Porvatov at sun.com>:
>   
>> I run the demo and it looks good.
>>     
> Thanks! I hope we can improve it so much to include it in the OpenJDK.
>
>   
>> Please take a look at my comments:
>> 1. Gaps between components differ from the original FileChooser
>>     
> Maybe do you refer to the Save Dialog? In the Open Dialog they are
> quite similar (see the attached screenshot)
>   
I'd add some space after the "Posizione:" text etc...
>   
>> 2. Some bitmaps differ from the original FileChooser
>>     
> Do you mean the small preview icons near the filename?
> This thumbs are in the folder /home/c.cerbo/.thumbnails/normal and
> their name is the md5 of the file uri, for example:
>   file:///home/c.cerbo/Documenti/Effective_Java.pdf   -->
> 6e1c7944eac7bc932b2b56c6ac94960f
> The bug was that the uri must be encoded according rfc2396 (see
> http://www.ietf.org/rfc/rfc2396.txt) and I didn't so, for example
>   file:///home/c.cerbo/Documenti/Ciao Belli.pdf  becames
> file:///home/c.cerbo/Documenti/Ciao%20Belli.pdf
>
> The new code looks so like (eu.kostia.gtkjfilechooser.GtkStockIcon):
> 	private static File lookForThumbs(File file) {
> 		String thumbsFolder = System.getProperty("user.home") + "/.thumbnails/normal";
> 		String md5 = md5(toFileuri(file));
>
> 		File thumn = new File(thumbsFolder + "/" + md5 + ".png");
>
> 		if (!thumn.exists()) {
> 			return null;
> 		}
> 		return thumn;
> 	}
>
> 	static String toFileuri(File file) {
> 		return file.toURI().toASCIIString().replace("file:", "file://");
> 	}
>
> Regarding the other icons, I get them directly from the actual
> implementation in the JDK:
> 	private static Icon getFromStock(String name, Size size) {
> 		try {
> 			Class<?> gtkStockIconClass =
> Class.forName("com.sun.java.swing.plaf.gtk.GTKStyle$GTKStockIcon");
> 			Constructor<?> constructor =
> gtkStockIconClass.getDeclaredConstructor(String.class, int.class);
> 			constructor.setAccessible(true);
> 			return (Icon) constructor.newInstance(name, size.ordinal());
> 		} catch (Exception ex) {
> 			return null;
> 		}
> 	}
>
>
>   
>> 3. I got some errors (see attach)
>>     
> How do you caused these exceptions? I cannot reproduce them.
> Do the folders '/home/fritz/Documents' and '/home/fritz/Music' really exist?
>   
Yes, they exist.
> They are some of the so-called "well known" user directories:
>
> $ cat ~/.config/user-dirs.dirs
> XDG_DESKTOP_DIR="$HOME/Scrivania"
> XDG_DOWNLOAD_DIR="$HOME/Download"
> XDG_TEMPLATES_DIR="$HOME/Modelli"
> XDG_PUBLICSHARE_DIR="$HOME/Pubblici"
> XDG_DOCUMENTS_DIR="$HOME/Documenti"
> XDG_MUSIC_DIR="$HOME/Musica"
> XDG_PICTURES_DIR="$HOME/Immagini"
> XDG_VIDEOS_DIR="$HOME/Video"
>
> Maybe did you manually delete them, but they are still in your ~/.gtk-bookmarks?
> Could you check please the content of that file?
>   
I attached that file
> Thanks for your support!
>
>   
Regards, Pavel
> Cheers,
> Costantino
>
> P.S.: Is there somebody else that may help to further test and improve
> the new GtkFileChooser? Now that Java is open source it can become a
> more important player in the desktop linux. Furthermore Gnome is also
> the standard desktop environment under the Sun OS (Solaris). It's
> really a pity, that the GTKLookAndFeel hasn't yet an updated
> FileChooser.
>   
>
> ------------------------------------------------------------------------
>

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: gtk-bookmarks
Url: http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20091113/fe762c88/attachment.ksh 

From Pavel.Porvatov at Sun.COM  Fri Nov 13 01:32:32 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Fri, 13 Nov 2009 12:32:32 +0300
Subject: <Swing Dev> [PATCH] 6179357: Generics: JList
In-Reply-To: <200911112329.58520.fbrunnerlist@gmx.ch>
References: <200903222003.05081.fbrunnerlist@gmx.ch>
	<200909280120.03003.fbrunnerlist@gmx.ch> <4AC0E891.2090307@sun.com>
	<200911112329.58520.fbrunnerlist@gmx.ch>
Message-ID: <4AFD27B0.704@sun.com>

Hi Florian,

> Hi Pavel,
>
> just my monthly status request: any news?
>   
Unfortunately I don't have any news about the bug.

Regards, Pavel
> -Florian
>
> Am Montag, 28. September 2009 schrieb Pavel Porvatov:
>   
>> Hi Florian,
>>
>>     
>>> Hi Pavel,
>>>
>>> did you have time to look at the patch already? What's the status?
>>>       
>> Yes, I combined your tests into one and it works. Unfortunately the fix
>> will be delayed because internal approve of the fix is not finished yet
>> (I was wrong when I wrote about approve completion, sorry)... I'll let
>> you know when I commit your fix.
>>
>> Regards, Pavel
>>
>>     
>>> -Florian
>>>
>>> Am Montag, 14. September 2009 schrieb Pavel Porvatov:
>>>       
>>>> Hi Florian,
>>>>
>>>> Thanks! I will continue work with your fix tomorrow.
>>>>
>>>>         
>>>>> Hi Pavel,
>>>>>
>>>>> here are some jtreg tests, which test the signatures of the changed API
>>>>> (raw & generic calls).
>>>>>
>>>>> Note that, of course, the generic tests won't even compile before the
>>>>> generic JList patch is applied. So, if you care, you could:
>>>>> - remove the generic tests (should be simple)
>>>>> - run the test with the unpatched version
>>>>> - check them in
>>>>> - upgrade the test along with the JList patch
>>>>> - run them again
>>>>> - check them both in
>>>>>
>>>>> Please also  check the license header and the test annotations.
>>>>>           
>>>> Ok, I'll do it.
>>>>
>>>> Regards, Pavel.
>>>>
>>>>         
>>>>> -Florian
>>>>>
>>>>> Am Donnerstag, 3. September 2009 schrieb Florian Brunner:
>>>>>           
>>>>>> Hi Pavel,
>>>>>>
>>>>>> great news! :-)
>>>>>>
>>>>>> I will have a look at jtreg.
>>>>>>
>>>>>> -Florian
>>>>>>
>>>>>> Pavel Porvatov schrieb:
>>>>>>             
>>>>>>> Hi Florian,
>>>>>>>
>>>>>>>               
>>>>>>>> any news about my patch? What is the status? I understand that
>>>>>>>> approving of the API is not a quick step, but then it's already 2-3
>>>>>>>> months. And we need to do the same for all the other planed API-
>>>>>>>> changes to "generify" Swing. It would be great if we could speed
>>>>>>>> things up a bit again.
>>>>>>>>                 
>>>>>>> The good news: the patch was approved on last Friday! So I can push
>>>>>>> it. But many people asked about regression tests. Could you please
>>>>>>> write such automatic tests for the fix. E.g.
>>>>>>>
>>>>>>> -----
>>>>>>>         String[] strings = new String[] {"A string"};
>>>>>>>
>>>>>>>         new JList(strings);
>>>>>>>
>>>>>>>         Vector v1 = new Vector();
>>>>>>>
>>>>>>>         new JList(v1);
>>>>>>>
>>>>>>>         Vector<String> v2 = new Vector<String>();
>>>>>>>
>>>>>>>         new JList(v2);
>>>>>>> -----
>>>>>>> etc.
>>>>>>>
>>>>>>> Here you can find some info about test framework:
>>>>>>> http://openjdk.java.net/jtreg/
>>>>>>>
>>>>>>> Thanks, Pavel.
>>>>>>>
>>>>>>>               
>>>>>>>> What do you estimate, how much more time this step takes?
>>>>>>>>
>>>>>>>> Thanks.
>>>>>>>> -Florian
>>>>>>>>
>>>>>>>> Am Mittwoch, 22. Juli 2009 schrieben Sie:
>>>>>>>>                 
>>>>>>>>> Hi Florian,
>>>>>>>>>
>>>>>>>>>                   
>>>>>>>>>> Hi Pavel,
>>>>>>>>>>
>>>>>>>>>> I hope you had nice holidays.
>>>>>>>>>>
>>>>>>>>>> Do you have any news about the patch?
>>>>>>>>>>                     
>>>>>>>>> I'm awaiting approve of API changes. It's not a very quick step
>>>>>>>>> because a lot of people should take a look at your changes and give
>>>>>>>>> approve for it...
>>>>>>>>>
>>>>>>>>> Regards, Pavel
>>>>>>>>>
>>>>>>>>>                   
>>>>>>>>>> -Florian
>>>>>>>>>>
>>>>>>>>>> Am Freitag, 19. Juni 2009 schrieb Florian Brunner:
>>>>>>>>>>                     
>>>>>>>>>>> Hi Pavel,
>>>>>>>>>>>
>>>>>>>>>>> enjoy your holidays! My holidays start from 27th June till 8th
>>>>>>>>>>> July, so
>>>>>>>>>>> we can continue the work on generics afterwards again.
>>>>>>>>>>>
>>>>>>>>>>> -Florian
>>>>>>>>>>>
>>>>>>>>>>> Am Donnerstag, 11. Juni 2009 schrieb Pavel Porvatov:
>>>>>>>>>>>                       
>
>
>   


From i30817 at gmail.com  Fri Nov 13 10:20:11 2009
From: i30817 at gmail.com (Paulo Levi)
Date: Fri, 13 Nov 2009 18:20:11 +0000
Subject: <Swing Dev> Fwd: Bug in ShellFolder.
In-Reply-To: <4AFD2CAD.5040405@sun.com>
References: <212322090911121824v4a49bc93k289e13b5bf689624@mail.gmail.com> 
	<4AFD2CAD.5040405@sun.com>
Message-ID: <212322090911131020s5fd705edx63475b1e07ac5fec@mail.gmail.com>

Forward. I already resolved it by serializing the string instead of
the file, but i thought you should know, if you don't already, why
people are seeing this exception on shutdown.


---------- Forwarded message ----------
From: Alan Bateman <Alan.Bateman at sun.com>
Date: Fri, Nov 13, 2009 at 9:53 AM
Subject: Re: Bug in ShellFolder.
To: Paulo Levi <i30817 at gmail.com>
Cc: nio-discuss at openjdk.java.net


Paulo Levi wrote:
>
> In this thread, i found a bug similar to a strange exception i was
> (not) seeing when overriding writeObject
>
> http://forums.java.net/jive/thread.jspa?threadID=31316&tstart=0
>
> I found that it occurs because of saving files returned by the
> filechooser (extensions of sun.awt.shell.ShellFolder) when trying to
> serialize on a shutdownhook,
> because serializing triggers some file operation that needs to send a
> task to a Executor that is already closed.
> I avoid it by:
> out.writeObject(new File(((File) first).getAbsolutePath()));
> Couldn't something equivalent be done in writeReplace be used for the
> same thing inside one of those classes?
>

Sorry, I can't help you here - I would suggest bringing it up on one
of the Swing forums or mailing lists.

-Alan.

From c.cerbo at gmail.com  Fri Nov 13 12:57:46 2009
From: c.cerbo at gmail.com (Costantino Cerbo)
Date: Fri, 13 Nov 2009 21:57:46 +0100
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
	match native GTK 2.4 widget
In-Reply-To: <4AFD0801.5030202@sun.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
	<4AF7EC85.2090303@sun.com>
	<6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>
	<4AFBEB20.6030601@sun.com>
	<6fbbec30911121321l33c88209g702b4118c642a3e1@mail.gmail.com>
	<4AFD0801.5030202@sun.com>
Message-ID: <6fbbec30911131257w11dfabe7i13cc04d30665aaeb@mail.gmail.com>

Hallo Pavel, Hallo everyone

I've added 15px after the label "Posizione:" ( = Location) exactly
like in the original GTK FileChooser.
The change is committed in the trunk and will be included in the next release.

Regarding the exception that you reported:

java.lang.IllegalArgumentException: /home/fritz/Documents doesn't exist.
       at eu.kostia.gtkjfilechooser.ui.FileBrowserPane.listDirectory(FileBrowserPane.java:164)
       at eu.kostia.gtkjfilechooser.ui.FileBrowserPane.setCurrentDir(FileBrowserPane.java:203)
       at eu.kostia.gtkjfilechooser.ui.GtkFileChooserUI.doDirectoryChanged(GtkFileChooserUI.java:1171)

it's thrown from this code in FileBrowserPane:
162: private void listDirectory(File dir,
javax.swing.filechooser.FileFilter swingFilter) {
163:		if (!dir.exists()) {
164:			throw new IllegalArgumentException(dir + " doesn't exist.");
165:		}

You say that the folder "/home/fritz/Documents" exists, therefore I
cannot understand why this exception occurs.
What do you think about?

You can also anonymously check out the latest project source code:
  svn checkout http://gtkjfilechooser.googlecode.com/svn/trunk/
gtkjfilechooser-read-only

If you want, or if somebody else ask for it, i can give the right to
commit directly in the svn repository.

Cheers,
Costantino

From fbrunnerlist at gmx.ch  Mon Nov 16 07:58:28 2009
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Mon, 16 Nov 2009 16:58:28 +0100
Subject: <Swing Dev> [PATCH] 6179357: Generics: JList
In-Reply-To: <4AFD27B0.704@sun.com>
References: <200903222003.05081.fbrunnerlist@gmx.ch>
	<200909280120.03003.fbrunnerlist@gmx.ch> <4AC0E891.2090307@sun.com>
	<200911112329.58520.fbrunnerlist@gmx.ch> <4AFD27B0.704@sun.com>
Message-ID: <4B0176A4.6090304@gmx.ch>

Hi Pavel,

Hmm, do you know where the problem lies? I understand that changes to 
the public API need thorough reviews, but it's already months. It would 
be great if we could continue with the work.

-Florian

Pavel Porvatov schrieb:
> Hi Florian,
>
>> Hi Pavel,
>>
>> just my monthly status request: any news?
>>   
> Unfortunately I don't have any news about the bug.
>
> Regards, Pavel
>> -Florian
>>
>> Am Montag, 28. September 2009 schrieb Pavel Porvatov:
>>  
>>> Hi Florian,
>>>
>>>    
>>>> Hi Pavel,
>>>>
>>>> did you have time to look at the patch already? What's the status?
>>>>       
>>> Yes, I combined your tests into one and it works. Unfortunately the fix
>>> will be delayed because internal approve of the fix is not finished yet
>>> (I was wrong when I wrote about approve completion, sorry)... I'll let
>>> you know when I commit your fix.
>>>
>>> Regards, Pavel
>>>
>>>    
>>>> -Florian
>>>>
>>>> Am Montag, 14. September 2009 schrieb Pavel Porvatov:
>>>>      
>>>>> Hi Florian,
>>>>>
>>>>> Thanks! I will continue work with your fix tomorrow.
>>>>>
>>>>>        
>>>>>> Hi Pavel,
>>>>>>
>>>>>> here are some jtreg tests, which test the signatures of the 
>>>>>> changed API
>>>>>> (raw & generic calls).
>>>>>>
>>>>>> Note that, of course, the generic tests won't even compile before 
>>>>>> the
>>>>>> generic JList patch is applied. So, if you care, you could:
>>>>>> - remove the generic tests (should be simple)
>>>>>> - run the test with the unpatched version
>>>>>> - check them in
>>>>>> - upgrade the test along with the JList patch
>>>>>> - run them again
>>>>>> - check them both in
>>>>>>
>>>>>> Please also  check the license header and the test annotations.
>>>>>>           
>>>>> Ok, I'll do it.
>>>>>
>>>>> Regards, Pavel.
>>>>>
>>>>>        
>>>>>> -Florian
>>>>>>
>>>>>> Am Donnerstag, 3. September 2009 schrieb Florian Brunner:
>>>>>>          
>>>>>>> Hi Pavel,
>>>>>>>
>>>>>>> great news! :-)
>>>>>>>
>>>>>>> I will have a look at jtreg.
>>>>>>>
>>>>>>> -Florian
>>>>>>>
>>>>>>> Pavel Porvatov schrieb:
>>>>>>>            
>>>>>>>> Hi Florian,
>>>>>>>>
>>>>>>>>              
>>>>>>>>> any news about my patch? What is the status? I understand that
>>>>>>>>> approving of the API is not a quick step, but then it's 
>>>>>>>>> already 2-3
>>>>>>>>> months. And we need to do the same for all the other planed API-
>>>>>>>>> changes to "generify" Swing. It would be great if we could speed
>>>>>>>>> things up a bit again.
>>>>>>>>>                 
>>>>>>>> The good news: the patch was approved on last Friday! So I can 
>>>>>>>> push
>>>>>>>> it. But many people asked about regression tests. Could you please
>>>>>>>> write such automatic tests for the fix. E.g.
>>>>>>>>
>>>>>>>> -----
>>>>>>>>         String[] strings = new String[] {"A string"};
>>>>>>>>
>>>>>>>>         new JList(strings);
>>>>>>>>
>>>>>>>>         Vector v1 = new Vector();
>>>>>>>>
>>>>>>>>         new JList(v1);
>>>>>>>>
>>>>>>>>         Vector<String> v2 = new Vector<String>();
>>>>>>>>
>>>>>>>>         new JList(v2);
>>>>>>>> -----
>>>>>>>> etc.
>>>>>>>>
>>>>>>>> Here you can find some info about test framework:
>>>>>>>> http://openjdk.java.net/jtreg/
>>>>>>>>
>>>>>>>> Thanks, Pavel.
>>>>>>>>
>>>>>>>>              
>>>>>>>>> What do you estimate, how much more time this step takes?
>>>>>>>>>
>>>>>>>>> Thanks.
>>>>>>>>> -Florian
>>>>>>>>>
>>>>>>>>> Am Mittwoch, 22. Juli 2009 schrieben Sie:
>>>>>>>>>                
>>>>>>>>>> Hi Florian,
>>>>>>>>>>
>>>>>>>>>>                  
>>>>>>>>>>> Hi Pavel,
>>>>>>>>>>>
>>>>>>>>>>> I hope you had nice holidays.
>>>>>>>>>>>
>>>>>>>>>>> Do you have any news about the patch?
>>>>>>>>>>>                     
>>>>>>>>>> I'm awaiting approve of API changes. It's not a very quick step
>>>>>>>>>> because a lot of people should take a look at your changes 
>>>>>>>>>> and give
>>>>>>>>>> approve for it...
>>>>>>>>>>
>>>>>>>>>> Regards, Pavel
>>>>>>>>>>
>>>>>>>>>>                  
>>>>>>>>>>> -Florian
>>>>>>>>>>>
>>>>>>>>>>> Am Freitag, 19. Juni 2009 schrieb Florian Brunner:
>>>>>>>>>>>                    
>>>>>>>>>>>> Hi Pavel,
>>>>>>>>>>>>
>>>>>>>>>>>> enjoy your holidays! My holidays start from 27th June till 8th
>>>>>>>>>>>> July, so
>>>>>>>>>>>> we can continue the work on generics afterwards again.
>>>>>>>>>>>>
>>>>>>>>>>>> -Florian
>>>>>>>>>>>>
>>>>>>>>>>>> Am Donnerstag, 11. Juni 2009 schrieb Pavel Porvatov:
>>>>>>>>>>>>                       
>>
>>
>>   
>


From Alexander.Potochkin at Sun.COM  Mon Nov 16 08:02:18 2009
From: Alexander.Potochkin at Sun.COM (Alexander Potochkin)
Date: Mon, 16 Nov 2009 19:02:18 +0300
Subject: <Swing Dev> [PATCH] 6179357: Generics: JList
In-Reply-To: <4B0176A4.6090304@gmx.ch>
References: <200903222003.05081.fbrunnerlist@gmx.ch>
	<200909280120.03003.fbrunnerlist@gmx.ch> <4AC0E891.2090307@sun.com>
	<200911112329.58520.fbrunnerlist@gmx.ch> <4AFD27B0.704@sun.com>
	<4B0176A4.6090304@gmx.ch>
Message-ID: <4B01778A.9090807@sun.com>

Hello Florian

> Hi Pavel,
> 
> Hmm, do you know where the problem lies? I understand that changes to 
> the public API need thorough reviews, but it's already months. It would 
> be great if we could continue with the work.

I'll try to speed up the process

We'll let you know about the results soon

Thanks
alexp

> 
> -Florian
> 
> Pavel Porvatov schrieb:
>> Hi Florian,
>>
>>> Hi Pavel,
>>>
>>> just my monthly status request: any news?
>>>   
>> Unfortunately I don't have any news about the bug.
>>
>> Regards, Pavel
>>> -Florian
>>>
>>> Am Montag, 28. September 2009 schrieb Pavel Porvatov:
>>>  
>>>> Hi Florian,
>>>>
>>>>   
>>>>> Hi Pavel,
>>>>>
>>>>> did you have time to look at the patch already? What's the status?
>>>>>       
>>>> Yes, I combined your tests into one and it works. Unfortunately the fix
>>>> will be delayed because internal approve of the fix is not finished yet
>>>> (I was wrong when I wrote about approve completion, sorry)... I'll let
>>>> you know when I commit your fix.
>>>>
>>>> Regards, Pavel
>>>>
>>>>   
>>>>> -Florian
>>>>>
>>>>> Am Montag, 14. September 2009 schrieb Pavel Porvatov:
>>>>>     
>>>>>> Hi Florian,
>>>>>>
>>>>>> Thanks! I will continue work with your fix tomorrow.
>>>>>>
>>>>>>       
>>>>>>> Hi Pavel,
>>>>>>>
>>>>>>> here are some jtreg tests, which test the signatures of the 
>>>>>>> changed API
>>>>>>> (raw & generic calls).
>>>>>>>
>>>>>>> Note that, of course, the generic tests won't even compile before 
>>>>>>> the
>>>>>>> generic JList patch is applied. So, if you care, you could:
>>>>>>> - remove the generic tests (should be simple)
>>>>>>> - run the test with the unpatched version
>>>>>>> - check them in
>>>>>>> - upgrade the test along with the JList patch
>>>>>>> - run them again
>>>>>>> - check them both in
>>>>>>>
>>>>>>> Please also  check the license header and the test annotations.
>>>>>>>           
>>>>>> Ok, I'll do it.
>>>>>>
>>>>>> Regards, Pavel.
>>>>>>
>>>>>>       
>>>>>>> -Florian
>>>>>>>
>>>>>>> Am Donnerstag, 3. September 2009 schrieb Florian Brunner:
>>>>>>>         
>>>>>>>> Hi Pavel,
>>>>>>>>
>>>>>>>> great news! :-)
>>>>>>>>
>>>>>>>> I will have a look at jtreg.
>>>>>>>>
>>>>>>>> -Florian
>>>>>>>>
>>>>>>>> Pavel Porvatov schrieb:
>>>>>>>>           
>>>>>>>>> Hi Florian,
>>>>>>>>>
>>>>>>>>>             
>>>>>>>>>> any news about my patch? What is the status? I understand that
>>>>>>>>>> approving of the API is not a quick step, but then it's 
>>>>>>>>>> already 2-3
>>>>>>>>>> months. And we need to do the same for all the other planed API-
>>>>>>>>>> changes to "generify" Swing. It would be great if we could speed
>>>>>>>>>> things up a bit again.
>>>>>>>>>>                 
>>>>>>>>> The good news: the patch was approved on last Friday! So I can 
>>>>>>>>> push
>>>>>>>>> it. But many people asked about regression tests. Could you please
>>>>>>>>> write such automatic tests for the fix. E.g.
>>>>>>>>>
>>>>>>>>> -----
>>>>>>>>>         String[] strings = new String[] {"A string"};
>>>>>>>>>
>>>>>>>>>         new JList(strings);
>>>>>>>>>
>>>>>>>>>         Vector v1 = new Vector();
>>>>>>>>>
>>>>>>>>>         new JList(v1);
>>>>>>>>>
>>>>>>>>>         Vector<String> v2 = new Vector<String>();
>>>>>>>>>
>>>>>>>>>         new JList(v2);
>>>>>>>>> -----
>>>>>>>>> etc.
>>>>>>>>>
>>>>>>>>> Here you can find some info about test framework:
>>>>>>>>> http://openjdk.java.net/jtreg/
>>>>>>>>>
>>>>>>>>> Thanks, Pavel.
>>>>>>>>>
>>>>>>>>>             
>>>>>>>>>> What do you estimate, how much more time this step takes?
>>>>>>>>>>
>>>>>>>>>> Thanks.
>>>>>>>>>> -Florian
>>>>>>>>>>
>>>>>>>>>> Am Mittwoch, 22. Juli 2009 schrieben Sie:
>>>>>>>>>>               
>>>>>>>>>>> Hi Florian,
>>>>>>>>>>>
>>>>>>>>>>>                 
>>>>>>>>>>>> Hi Pavel,
>>>>>>>>>>>>
>>>>>>>>>>>> I hope you had nice holidays.
>>>>>>>>>>>>
>>>>>>>>>>>> Do you have any news about the patch?
>>>>>>>>>>>>                     
>>>>>>>>>>> I'm awaiting approve of API changes. It's not a very quick step
>>>>>>>>>>> because a lot of people should take a look at your changes 
>>>>>>>>>>> and give
>>>>>>>>>>> approve for it...
>>>>>>>>>>>
>>>>>>>>>>> Regards, Pavel
>>>>>>>>>>>
>>>>>>>>>>>                 
>>>>>>>>>>>> -Florian
>>>>>>>>>>>>
>>>>>>>>>>>> Am Freitag, 19. Juni 2009 schrieb Florian Brunner:
>>>>>>>>>>>>                   
>>>>>>>>>>>>> Hi Pavel,
>>>>>>>>>>>>>
>>>>>>>>>>>>> enjoy your holidays! My holidays start from 27th June till 8th
>>>>>>>>>>>>> July, so
>>>>>>>>>>>>> we can continue the work on generics afterwards again.
>>>>>>>>>>>>>
>>>>>>>>>>>>> -Florian
>>>>>>>>>>>>>
>>>>>>>>>>>>> Am Donnerstag, 11. Juni 2009 schrieb Pavel Porvatov:
>>>>>>>>>>>>>                       
>>>
>>>
>>>   
>>
> 


From fbrunnerlist at gmx.ch  Mon Nov 16 08:26:17 2009
From: fbrunnerlist at gmx.ch (Florian Brunner)
Date: Mon, 16 Nov 2009 17:26:17 +0100
Subject: <Swing Dev> [PATCH] 6179357: Generics: JList
In-Reply-To: <4B01778A.9090807@sun.com>
References: <200903222003.05081.fbrunnerlist@gmx.ch>
	<200909280120.03003.fbrunnerlist@gmx.ch> <4AC0E891.2090307@sun.com>
	<200911112329.58520.fbrunnerlist@gmx.ch> <4AFD27B0.704@sun.com>
	<4B0176A4.6090304@gmx.ch> <4B01778A.9090807@sun.com>
Message-ID: <4B017D29.1090300@gmx.ch>

Ok, thanks

-Florian

Alexander Potochkin schrieb:
> Hello Florian
>
>> Hi Pavel,
>>
>> Hmm, do you know where the problem lies? I understand that changes to 
>> the public API need thorough reviews, but it's already months. It 
>> would be great if we could continue with the work.
>
> I'll try to speed up the process
>
> We'll let you know about the results soon
>
> Thanks
> alexp
>
>>
>> -Florian
>>
>> Pavel Porvatov schrieb:
>>> Hi Florian,
>>>
>>>> Hi Pavel,
>>>>
>>>> just my monthly status request: any news?
>>>>   
>>> Unfortunately I don't have any news about the bug.
>>>
>>> Regards, Pavel
>>>> -Florian
>>>>
>>>> Am Montag, 28. September 2009 schrieb Pavel Porvatov:
>>>>  
>>>>> Hi Florian,
>>>>>
>>>>>  
>>>>>> Hi Pavel,
>>>>>>
>>>>>> did you have time to look at the patch already? What's the status?
>>>>>>       
>>>>> Yes, I combined your tests into one and it works. Unfortunately 
>>>>> the fix
>>>>> will be delayed because internal approve of the fix is not 
>>>>> finished yet
>>>>> (I was wrong when I wrote about approve completion, sorry)... I'll 
>>>>> let
>>>>> you know when I commit your fix.
>>>>>
>>>>> Regards, Pavel
>>>>>
>>>>>  
>>>>>> -Florian
>>>>>>
>>>>>> Am Montag, 14. September 2009 schrieb Pavel Porvatov:
>>>>>>    
>>>>>>> Hi Florian,
>>>>>>>
>>>>>>> Thanks! I will continue work with your fix tomorrow.
>>>>>>>
>>>>>>>      
>>>>>>>> Hi Pavel,
>>>>>>>>
>>>>>>>> here are some jtreg tests, which test the signatures of the 
>>>>>>>> changed API
>>>>>>>> (raw & generic calls).
>>>>>>>>
>>>>>>>> Note that, of course, the generic tests won't even compile 
>>>>>>>> before the
>>>>>>>> generic JList patch is applied. So, if you care, you could:
>>>>>>>> - remove the generic tests (should be simple)
>>>>>>>> - run the test with the unpatched version
>>>>>>>> - check them in
>>>>>>>> - upgrade the test along with the JList patch
>>>>>>>> - run them again
>>>>>>>> - check them both in
>>>>>>>>
>>>>>>>> Please also  check the license header and the test annotations.
>>>>>>>>           
>>>>>>> Ok, I'll do it.
>>>>>>>
>>>>>>> Regards, Pavel.
>>>>>>>
>>>>>>>      
>>>>>>>> -Florian
>>>>>>>>
>>>>>>>> Am Donnerstag, 3. September 2009 schrieb Florian Brunner:
>>>>>>>>        
>>>>>>>>> Hi Pavel,
>>>>>>>>>
>>>>>>>>> great news! :-)
>>>>>>>>>
>>>>>>>>> I will have a look at jtreg.
>>>>>>>>>
>>>>>>>>> -Florian
>>>>>>>>>
>>>>>>>>> Pavel Porvatov schrieb:
>>>>>>>>>          
>>>>>>>>>> Hi Florian,
>>>>>>>>>>
>>>>>>>>>>            
>>>>>>>>>>> any news about my patch? What is the status? I understand that
>>>>>>>>>>> approving of the API is not a quick step, but then it's 
>>>>>>>>>>> already 2-3
>>>>>>>>>>> months. And we need to do the same for all the other planed 
>>>>>>>>>>> API-
>>>>>>>>>>> changes to "generify" Swing. It would be great if we could 
>>>>>>>>>>> speed
>>>>>>>>>>> things up a bit again.
>>>>>>>>>>>                 
>>>>>>>>>> The good news: the patch was approved on last Friday! So I 
>>>>>>>>>> can push
>>>>>>>>>> it. But many people asked about regression tests. Could you 
>>>>>>>>>> please
>>>>>>>>>> write such automatic tests for the fix. E.g.
>>>>>>>>>>
>>>>>>>>>> -----
>>>>>>>>>>         String[] strings = new String[] {"A string"};
>>>>>>>>>>
>>>>>>>>>>         new JList(strings);
>>>>>>>>>>
>>>>>>>>>>         Vector v1 = new Vector();
>>>>>>>>>>
>>>>>>>>>>         new JList(v1);
>>>>>>>>>>
>>>>>>>>>>         Vector<String> v2 = new Vector<String>();
>>>>>>>>>>
>>>>>>>>>>         new JList(v2);
>>>>>>>>>> -----
>>>>>>>>>> etc.
>>>>>>>>>>
>>>>>>>>>> Here you can find some info about test framework:
>>>>>>>>>> http://openjdk.java.net/jtreg/
>>>>>>>>>>
>>>>>>>>>> Thanks, Pavel.
>>>>>>>>>>
>>>>>>>>>>            
>>>>>>>>>>> What do you estimate, how much more time this step takes?
>>>>>>>>>>>
>>>>>>>>>>> Thanks.
>>>>>>>>>>> -Florian
>>>>>>>>>>>
>>>>>>>>>>> Am Mittwoch, 22. Juli 2009 schrieben Sie:
>>>>>>>>>>>              
>>>>>>>>>>>> Hi Florian,
>>>>>>>>>>>>
>>>>>>>>>>>>                
>>>>>>>>>>>>> Hi Pavel,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I hope you had nice holidays.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Do you have any news about the patch?
>>>>>>>>>>>>>                     
>>>>>>>>>>>> I'm awaiting approve of API changes. It's not a very quick 
>>>>>>>>>>>> step
>>>>>>>>>>>> because a lot of people should take a look at your changes 
>>>>>>>>>>>> and give
>>>>>>>>>>>> approve for it...
>>>>>>>>>>>>
>>>>>>>>>>>> Regards, Pavel
>>>>>>>>>>>>
>>>>>>>>>>>>                
>>>>>>>>>>>>> -Florian
>>>>>>>>>>>>>
>>>>>>>>>>>>> Am Freitag, 19. Juni 2009 schrieb Florian Brunner:
>>>>>>>>>>>>>                  
>>>>>>>>>>>>>> Hi Pavel,
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> enjoy your holidays! My holidays start from 27th June 
>>>>>>>>>>>>>> till 8th
>>>>>>>>>>>>>> July, so
>>>>>>>>>>>>>> we can continue the work on generics afterwards again.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> -Florian
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Am Donnerstag, 11. Juni 2009 schrieb Pavel Porvatov:
>>>>>>>>>>>>>>                       
>>>>
>>>>
>>>>   
>>>
>>
>


From pavel.porvatov at sun.com  Tue Nov 17 05:03:02 2009
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Tue, 17 Nov 2009 13:03:02 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6868611: FileSystemView
	throws	NullPointerException
Message-ID: <20091117130351.5E73D41C91@hg.openjdk.java.net>

Changeset: 86be1dc90f57
Author:    rupashka
Date:      2009-11-17 16:01 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/86be1dc90f57

6868611: FileSystemView throws NullPointerException
Reviewed-by: peterz

! src/share/classes/javax/swing/filechooser/FileSystemView.java
+ test/javax/swing/JFileChooser/6868611/bug6868611.java


From Pavel.Porvatov at Sun.COM  Tue Nov 17 05:55:56 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Tue, 17 Nov 2009 16:55:56 +0300
Subject: <Swing Dev> Fwd: Bug in ShellFolder.
In-Reply-To: <212322090911131020s5fd705edx63475b1e07ac5fec@mail.gmail.com>
References: <212322090911121824v4a49bc93k289e13b5bf689624@mail.gmail.com>
	<4AFD2CAD.5040405@sun.com>
	<212322090911131020s5fd705edx63475b1e07ac5fec@mail.gmail.com>
Message-ID: <4B02AB6C.203@sun.com>

Hi Paulo,

I'll take a look at the problem and let you know the result...

Thanks, Pavel
> Forward. I already resolved it by serializing the string instead of
> the file, but i thought you should know, if you don't already, why
> people are seeing this exception on shutdown.
>
>
> ---------- Forwarded message ----------
> From: Alan Bateman <Alan.Bateman at sun.com>
> Date: Fri, Nov 13, 2009 at 9:53 AM
> Subject: Re: Bug in ShellFolder.
> To: Paulo Levi <i30817 at gmail.com>
> Cc: nio-discuss at openjdk.java.net
>
>
> Paulo Levi wrote:
>   
>> In this thread, i found a bug similar to a strange exception i was
>> (not) seeing when overriding writeObject
>>
>> http://forums.java.net/jive/thread.jspa?threadID=31316&tstart=0
>>
>> I found that it occurs because of saving files returned by the
>> filechooser (extensions of sun.awt.shell.ShellFolder) when trying to
>> serialize on a shutdownhook,
>> because serializing triggers some file operation that needs to send a
>> task to a Executor that is already closed.
>> I avoid it by:
>> out.writeObject(new File(((File) first).getAbsolutePath()));
>> Couldn't something equivalent be done in writeReplace be used for the
>> same thing inside one of those classes?
>>
>>     
>
> Sorry, I can't help you here - I would suggest bringing it up on one
> of the Swing forums or mailing lists.
>
> -Alan.
>   


From pavel.porvatov at sun.com  Wed Nov 18 02:01:00 2009
From: pavel.porvatov at sun.com (pavel.porvatov at sun.com)
Date: Wed, 18 Nov 2009 10:01:00 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6520574: JFileChooser - create new
	folder - not	editable
Message-ID: <20091118100143.22B9A41DEF@hg.openjdk.java.net>

Changeset: 4f0275ea56fd
Author:    rupashka
Date:      2009-11-18 12:58 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/4f0275ea56fd

6520574: JFileChooser - create new folder - not editable
Reviewed-by: malenkov

! src/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java


From Pavel.Porvatov at Sun.COM  Wed Nov 18 06:01:01 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Wed, 18 Nov 2009 17:01:01 +0300
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
 match native GTK 2.4 widget
In-Reply-To: <6fbbec30911131257w11dfabe7i13cc04d30665aaeb@mail.gmail.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
	<4AF7EC85.2090303@sun.com>
	<6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>
	<4AFBEB20.6030601@sun.com>
	<6fbbec30911121321l33c88209g702b4118c642a3e1@mail.gmail.com>
	<4AFD0801.5030202@sun.com>
	<6fbbec30911131257w11dfabe7i13cc04d30665aaeb@mail.gmail.com>
Message-ID: <4B03FE1D.7020808@sun.com>

Hi Costantino,
> Hallo Pavel, Hallo everyone
>
> I've added 15px after the label "Posizione:" ( = Location) exactly
> like in the original GTK FileChooser.
> The change is committed in the trunk and will be included in the next release.
>
> Regarding the exception that you reported:
>
> java.lang.IllegalArgumentException: /home/fritz/Documents doesn't exist.
>        at eu.kostia.gtkjfilechooser.ui.FileBrowserPane.listDirectory(FileBrowserPane.java:164)
>        at eu.kostia.gtkjfilechooser.ui.FileBrowserPane.setCurrentDir(FileBrowserPane.java:203)
>        at eu.kostia.gtkjfilechooser.ui.GtkFileChooserUI.doDirectoryChanged(GtkFileChooserUI.java:1171)
>
> it's thrown from this code in FileBrowserPane:
> 162: private void listDirectory(File dir,
> javax.swing.filechooser.FileFilter swingFilter) {
> 163:		if (!dir.exists()) {
> 164:			throw new IllegalArgumentException(dir + " doesn't exist.");
> 165:		}
>
> You say that the folder "/home/fritz/Documents" exists, therefore I
> cannot understand why this exception occurs.
> What do you think about?
>
> You can also anonymously check out the latest project source code:
>   svn checkout http://gtkjfilechooser.googlecode.com/svn/trunk/
> gtkjfilechooser-read-only
>
> If you want, or if somebody else ask for it, i can give the right to
> commit directly in the svn repository.
>   
If you'd like to contribute some sources for openjdk, you have to become 
a contributor (details are here: http://openjdk.java.net/contribute/).

To develop some new components or extend an existing one I'd recommend 
to use the official site dev.java.net. You have to pass some steps:
1. Become a contributor: https://sca.dev.java.net/
2. Create a new project: http://www.java.net/request-project

After that your project will be more official and you could get feedback 
from Sun employers and other people.

Regards, Pavel
> Cheers,
> Costantino
>   


From peter.zhelezniakov at sun.com  Wed Nov 18 06:37:29 2009
From: peter.zhelezniakov at sun.com (peter.zhelezniakov at sun.com)
Date: Wed, 18 Nov 2009 14:37:29 +0000
Subject: <Swing Dev> hg: jdk7/swing/jdk: 6882917: Nimbus and
	DefaultTableCellRenderer:	must start with normal background
Message-ID: <20091118143809.C6EF741E3B@hg.openjdk.java.net>

Changeset: fc3997fd1bce
Author:    peterz
Date:      2009-11-18 17:36 +0300
URL:       http://hg.openjdk.java.net/jdk7/swing/jdk/rev/fc3997fd1bce

6882917: Nimbus and DefaultTableCellRenderer: must start with normal background
Reviewed-by: rupashka

! src/share/classes/javax/swing/plaf/synth/SynthTableUI.java
! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java


From c.cerbo at gmail.com  Wed Nov 18 11:43:51 2009
From: c.cerbo at gmail.com (Costantino Cerbo)
Date: Wed, 18 Nov 2009 20:43:51 +0100
Subject: <Swing Dev> Issue 5090726 - GTK L&F: Need new FileChooserUI to
	match native GTK 2.4 widget
In-Reply-To: <4B03FE1D.7020808@sun.com>
References: <6fbbec30911061742p6b836a7draee750f1ba40e639@mail.gmail.com>
	<4AF7EC85.2090303@sun.com>
	<6fbbec30911090336x3d31c16ue748563d506ace68@mail.gmail.com>
	<4AFBEB20.6030601@sun.com>
	<6fbbec30911121321l33c88209g702b4118c642a3e1@mail.gmail.com>
	<4AFD0801.5030202@sun.com>
	<6fbbec30911131257w11dfabe7i13cc04d30665aaeb@mail.gmail.com>
	<4B03FE1D.7020808@sun.com>
Message-ID: <6fbbec30911181143r2bf0dba2v747203b1e852a443@mail.gmail.com>

Hello Pavel,

Thanks for you tips!

I've posted a signed copy of the "Sun Contributor Agreement" to
sun_ca at sun.com and created the following project on java.net
(approvation still pending):
  http://www.java.net/project/updated-gtk24-jfilechooserui-swing-gtk-look-and-feel

I'm looking forward to receiving Sun's feedback!

Regards,
Costantino

From Pavel.Porvatov at Sun.COM  Thu Nov 19 03:23:46 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Thu, 19 Nov 2009 14:23:46 +0300
Subject: <Swing Dev> Fwd: Bug in ShellFolder.
In-Reply-To: <212322090911131020s5fd705edx63475b1e07ac5fec@mail.gmail.com>
References: <212322090911121824v4a49bc93k289e13b5bf689624@mail.gmail.com>
	<4AFD2CAD.5040405@sun.com>
	<212322090911131020s5fd705edx63475b1e07ac5fec@mail.gmail.com>
Message-ID: <4B052AC2.1020809@sun.com>

Hi Paulo,

The problem is described in the bug 6612928:
Since 6u2 b01 we use the concurrent package to marshall COM calls to the 
dedicated thread. The investigation shows that this exception is thrown 
with a scenario like this:

1) user exits the application
2) the JVM starts invoking shutdown hooks
3) the COM thread's shutdown hook initiates shutdown of 
ThreadPoolExecutor (used for marshalling COM calls to the dedicated thread)
4) a new COM call is submitted from within another thread

> Couldn't something equivalent be done in writeReplace be used for the
> same thing inside one of those classes?
Therefore you shouldn't call any methods that use COM thread after a 
shutdownhook. As a temporary workaround you can try to cache values for 
serialization BEFORE a shutdownhook is initialized.

Regards, Pavel
> Forward. I already resolved it by serializing the string instead of
> the file, but i thought you should know, if you don't already, why
> people are seeing this exception on shutdown.
>
>
> ---------- Forwarded message ----------
> From: Alan Bateman <Alan.Bateman at sun.com>
> Date: Fri, Nov 13, 2009 at 9:53 AM
> Subject: Re: Bug in ShellFolder.
> To: Paulo Levi <i30817 at gmail.com>
> Cc: nio-discuss at openjdk.java.net
>
>
> Paulo Levi wrote:
>   
>> In this thread, i found a bug similar to a strange exception i was
>> (not) seeing when overriding writeObject
>>
>> http://forums.java.net/jive/thread.jspa?threadID=31316&tstart=0
>>
>> I found that it occurs because of saving files returned by the
>> filechooser (extensions of sun.awt.shell.ShellFolder) when trying to
>> serialize on a shutdownhook,
>> because serializing triggers some file operation that needs to send a
>> task to a Executor that is already closed.
>> I avoid it by:
>> out.writeObject(new File(((File) first).getAbsolutePath()));
>> Couldn't something equivalent be done in writeReplace be used for the
>> same thing inside one of those classes?
>>
>>     
>
> Sorry, I can't help you here - I would suggest bringing it up on one
> of the Swing forums or mailing lists.
>
> -Alan.
>   


From i30817 at gmail.com  Thu Nov 19 10:18:19 2009
From: i30817 at gmail.com (Paulo Levi)
Date: Thu, 19 Nov 2009 18:18:19 +0000
Subject: <Swing Dev> Fwd: Bug in ShellFolder.
In-Reply-To: <4B052AC2.1020809@sun.com>
References: <212322090911121824v4a49bc93k289e13b5bf689624@mail.gmail.com> 
	<4AFD2CAD.5040405@sun.com>
	<212322090911131020s5fd705edx63475b1e07ac5fec@mail.gmail.com> 
	<4B052AC2.1020809@sun.com>
Message-ID: <212322090911191018t745d1a23q4f1e3800b101239b@mail.gmail.com>

So it is a won't fix then?
Seems really short-sighted, since probably forever people will want to
serialize things when shutting down the application.
Anyway the only operation i found that uses the COM thread is the
shellfolder2 class. I'm sure at least this very common case can be worked
around i its serialization routine.

On Thu, Nov 19, 2009 at 11:23 AM, Pavel Porvatov <Pavel.Porvatov at sun.com>wrote:

> Hi Paulo,
>
> The problem is described in the bug 6612928:
> Since 6u2 b01 we use the concurrent package to marshall COM calls to the
> dedicated thread. The investigation shows that this exception is thrown with
> a scenario like this:
>
> 1) user exits the application
> 2) the JVM starts invoking shutdown hooks
> 3) the COM thread's shutdown hook initiates shutdown of ThreadPoolExecutor
> (used for marshalling COM calls to the dedicated thread)
> 4) a new COM call is submitted from within another thread
>
>
>  Couldn't something equivalent be done in writeReplace be used for the
>> same thing inside one of those classes?
>>
> Therefore you shouldn't call any methods that use COM thread after a
> shutdownhook. As a temporary workaround you can try to cache values for
> serialization BEFORE a shutdownhook is initialized.
>
> Regards, Pavel
>
>  Forward. I already resolved it by serializing the string instead of
>> the file, but i thought you should know, if you don't already, why
>> people are seeing this exception on shutdown.
>>
>>
>> ---------- Forwarded message ----------
>> From: Alan Bateman <Alan.Bateman at sun.com>
>> Date: Fri, Nov 13, 2009 at 9:53 AM
>> Subject: Re: Bug in ShellFolder.
>> To: Paulo Levi <i30817 at gmail.com>
>> Cc: nio-discuss at openjdk.java.net
>>
>>
>> Paulo Levi wrote:
>>
>>
>>> In this thread, i found a bug similar to a strange exception i was
>>> (not) seeing when overriding writeObject
>>>
>>> http://forums.java.net/jive/thread.jspa?threadID=31316&tstart=0
>>>
>>> I found that it occurs because of saving files returned by the
>>> filechooser (extensions of sun.awt.shell.ShellFolder) when trying to
>>> serialize on a shutdownhook,
>>> because serializing triggers some file operation that needs to send a
>>> task to a Executor that is already closed.
>>> I avoid it by:
>>> out.writeObject(new File(((File) first).getAbsolutePath()));
>>> Couldn't something equivalent be done in writeReplace be used for the
>>> same thing inside one of those classes?
>>>
>>>
>>>
>>
>> Sorry, I can't help you here - I would suggest bringing it up on one
>> of the Swing forums or mailing lists.
>>
>> -Alan.
>>
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20091119/3cfa5fb4/attachment.html 

From Pavel.Porvatov at Sun.COM  Thu Nov 19 23:55:36 2009
From: Pavel.Porvatov at Sun.COM (Pavel Porvatov)
Date: Fri, 20 Nov 2009 10:55:36 +0300
Subject: <Swing Dev> Fwd: Bug in ShellFolder.
In-Reply-To: <212322090911191018t745d1a23q4f1e3800b101239b@mail.gmail.com>
References: <212322090911121824v4a49bc93k289e13b5bf689624@mail.gmail.com>
	<4AFD2CAD.5040405@sun.com>
	<212322090911131020s5fd705edx63475b1e07ac5fec@mail.gmail.com>
	<4B052AC2.1020809@sun.com>
	<212322090911191018t745d1a23q4f1e3800b101239b@mail.gmail.com>
Message-ID: <4B064B78.1030603@sun.com>

Hi Paulo,
> So it is a won't fix then?
Who say that? There is a bug. It has not the highest priority and it's 
the reason why it still not fixed.

Regards, Pavel.
> Seems really short-sighted, since probably forever people will want to 
> serialize things when shutting down the application.
> Anyway the only operation i found that uses the COM thread is the 
> shellfolder2 class. I'm sure at least this very common case can be 
> worked around i its serialization routine.
>
> On Thu, Nov 19, 2009 at 11:23 AM, Pavel Porvatov 
> <Pavel.Porvatov at sun.com <mailto:Pavel.Porvatov at sun.com>> wrote:
>
>     Hi Paulo,
>
>     The problem is described in the bug 6612928:
>     Since 6u2 b01 we use the concurrent package to marshall COM calls
>     to the dedicated thread. The investigation shows that this
>     exception is thrown with a scenario like this:
>
>     1) user exits the application
>     2) the JVM starts invoking shutdown hooks
>     3) the COM thread's shutdown hook initiates shutdown of
>     ThreadPoolExecutor (used for marshalling COM calls to the
>     dedicated thread)
>     4) a new COM call is submitted from within another thread
>
>
>         Couldn't something equivalent be done in writeReplace be used
>         for the
>         same thing inside one of those classes?
>
>     Therefore you shouldn't call any methods that use COM thread after
>     a shutdownhook. As a temporary workaround you can try to cache
>     values for serialization BEFORE a shutdownhook is initialized.
>
>     Regards, Pavel
>
>         Forward. I already resolved it by serializing the string
>         instead of
>         the file, but i thought you should know, if you don't already, why
>         people are seeing this exception on shutdown.
>
>
>         ---------- Forwarded message ----------
>         From: Alan Bateman <Alan.Bateman at sun.com
>         <mailto:Alan.Bateman at sun.com>>
>         Date: Fri, Nov 13, 2009 at 9:53 AM
>         Subject: Re: Bug in ShellFolder.
>         To: Paulo Levi <i30817 at gmail.com <mailto:i30817 at gmail.com>>
>         Cc: nio-discuss at openjdk.java.net
>         <mailto:nio-discuss at openjdk.java.net>
>
>
>         Paulo Levi wrote:
>          
>
>             In this thread, i found a bug similar to a strange
>             exception i was
>             (not) seeing when overriding writeObject
>
>             http://forums.java.net/jive/thread.jspa?threadID=31316&tstart=0
>             <http://forums.java.net/jive/thread.jspa?threadID=31316&tstart=0>
>
>             I found that it occurs because of saving files returned by the
>             filechooser (extensions of sun.awt.shell.ShellFolder) when
>             trying to
>             serialize on a shutdownhook,
>             because serializing triggers some file operation that
>             needs to send a
>             task to a Executor that is already closed.
>             I avoid it by:
>             out.writeObject(new File(((File) first).getAbsolutePath()));
>             Couldn't something equivalent be done in writeReplace be
>             used for the
>             same thing inside one of those classes?
>
>                
>
>
>         Sorry, I can't help you here - I would suggest bringing it up
>         on one
>         of the Swing forums or mailing lists.
>
>         -Alan.
>          
>
>
>