<Swing Dev>  Review Request: 8189656 The Windows L&F should be moved out from the shared folder
Sergey.Bylokhov at oracle.com
Tue Nov 28 22:11:38 UTC 2017
On 28/11/2017 13:38, Phil Race wrote:
> I see this opens was moved to platform-specific code ... 115 opens
> com.sun.java.swing.plaf.windows to
> 116 jdk.jconsole;
> So jdk.jconsole definitely accesses this only on Windows ?
Its is accessed under the windows check:
String lafName = UIManager.getLookAndFeel().getClass().getName();
> On 11/28/2017 09:28 AM, Erik Joelsson wrote:
>> From a build point of view, this looks great.
>> On 2017-11-27 18:27, Sergey Bylokhov wrote:
>>> Please review the fix for jdk10. This is the second attempt to move
>>> windows L&F from non-windows platforms. The first attempt
>>> JDK-6461834 was reverted because of JDK-8184813.
>>> The root cause of those issue was fixed in JDK-8075255, and now we
>>> can move it again.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8189656
>>> Webrev can be found at:
>>> The fix contains a few parts:
>>> - The code related to win l&f was moved from the "share" to the
>>> "windows" folder
>>> - The platform-specific export was moved from module-info.java to
>>> - A number of tests which use windows L&F were marked as
>>> - The stub "ThemeReader.java" which was used to build win w&f on
>>> unix was removed.
>>>  https://bugs.openjdk.java.net/browse/JDK-6461834
>>>  https://bugs.openjdk.java.net/browse/JDK-8184813
>>>  https://bugs.openjdk.java.net/browse/JDK-8075255
Best regards, Sergey.
More information about the swing-dev