<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Alexandr,<div class=""><br class=""></div><div class="">Automated test may fail based on folder contents on individual systems irrespective of the fix directly not depending on the same. <div class="">Also, to confirm this fix, it will need visual confirmation and hence, no automated test was provided.</div><div class=""><br class=""></div><div class="">With Regards,</div><div class="">Avik Niyogi<br class=""><div><blockquote type="cite" class=""><div class="">On 23-Dec-2015, at 7:32 pm, Alexander Scherbatiy <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type" class="">
<div text="#000000" bgcolor="#FFFFFF" class="">
<div class="moz-cite-prefix"><br class="">
<br class="">
The fix looks good to me.<br class="">
<br class="">
Is it possible to write an automated test for the fix?<br class="">
<br class="">
Thanks,<br class="">
Alexandr.<br class="">
<br class="">
On 12/21/2015 2:55 PM, Avik Niyogi wrote:<br class="">
</div>
<blockquote cite="mid:830F92CE-33CC-42B5-BA07-8E1BB179D7E9@oracle.com" type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1" class="">
Hi All,
<div class=""><br class="">
</div>
<div class="">Kindly review the bug fix for JDK 9.</div>
<div class=""><br class="">
</div>
<div class=""><b class="">Bug:</b></div>
<div class=""><a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8016665" class="">https://bugs.openjdk.java.net/browse/JDK-8016665</a></div>
<div class=""><br class="">
</div>
<div class=""><b class="">Webrev:</b></div>
<div class=""><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Eaniyogi/8016665/webrev.00/" class="">http://cr.openjdk.java.net/~aniyogi/8016665/webrev.00/</a></div>
<div class=""><br class="">
</div>
<div class=""><b class="">Issue:</b></div>
<div class="">The manual test:
Swing_AllComponents/Manual/I18nSwingTests</div>
<div class="">in testsuite <a moz-do-not-send="true" href="http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/7/swing" class="">http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/7/swing</a> fails.</div>
<div class=""><br class="">
</div>
<div class="">
<div class=""><b class="">Cause:</b></div>
<div class="">Due to not honouring of RIGHT_TO_LEFT parameter
for setOrientation method applied for a JFileChooser for the
AquaLookAndFeel only,</div>
<div class="">the fileChooser does not get displayed in
RIGHT_TO_LEFT orientation. </div>
<div class="">This issue was verified to exist only in
AquaLookAndFeel for JFileChooser only due to wrong
implementation in AquaFileSystemModel.</div>
<div class="">Also, as provided in comments: "The Aqua LAF must
support the RTL orientation of JFileChooser."</div>
<div class=""><br class="">
</div>
<div class=""><b class="">Fix:</b></div>
<div class="">Added implementation for the check of
RIGHT_TO_LEFT ComponentOrientation and verified with test
suite.</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">With Regards,</div>
<div class="">Avik Niyogi</div>
</div>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></div></div></body></html>