<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi All,<div class="">Please find changes as provided with incorporation of inputs:</div><div class=""><a href="http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/" class="">http://cr.openjdk.java.net/~aniyogi/8015748/webrev.04/</a></div><div class=""><br class=""></div><div class="">With Regards,</div><div class="">Avik Niyogi<br class=""><div><blockquote type="cite" class=""><div class="">On 13-Jan-2016, at 7:02 pm, Alexander Scherbatiy <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">On 1/13/2016 9:28 AM, Avik Niyogi wrote:<br class=""><blockquote type="cite" class="">Hi All,<br class="">Please find changes as provided with incorporation of inputs:<br class=""><a href="http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/" class="">http://cr.openjdk.java.net/~aniyogi/8015748/webrev.03/</a> <<a href="http://cr.openjdk.java.net/%7Eaniyogi/8015748/webrev.03/" class="">http://cr.openjdk.java.net/%7Eaniyogi/8015748/webrev.03/</a>><br class=""><br class=""></blockquote><br class=""> It looks like a string on a vertical progress bar with the right to left orientation will be mirrored.<br class=""> Did you try just restore the scale/translate transform after the painter.paint() call? Will it help in such case?<br class=""><br class=""> Thanks,<br class=""> Alexandr.<br class=""><br class=""><blockquote type="cite" class="">With Regards,<br class="">Avik Niyogi<br class=""><blockquote type="cite" class="">On 12-Jan-2016, at 11:49 pm, Alexander Scherbatiy <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a> <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">mailto:alexandr.scherbatiy@oracle.com</a>>> wrote:<br class=""><br class=""><br class="">- there was the comment below that it is better to revert the transform back after the painter.paint() call<br class="">- according to the comment from the <a href="http://mail.openjdk.java.net/pipermail/swing-dev/2016-January/005262.html" class="">http://mail.openjdk.java.net/pipermail/swing-dev/2016-January/005262.html</a><br class=""><br class=""> It is true that a filled progress bar has different colors because of animation under Aqua L&F.<br class=""> However, it is possible to compare colors before a progress bar was filled and after that to check that the progress bar is filled from the correct side.<br class=""> For example let's set a progress bar value to 0 and get its color from 5/6 of the progress bar width<br class=""> progress bar: [_________o__] // get a color at point o<br class=""> Now set the progress bar value to 30 and get a color at the same point.<br class=""> If colors are the same then the progress bar is filled from left to the right [||||_____o__].<br class=""> If colors are different then the progress bar is filled from the right to the left [________|o||] .<br class=""><br class=""> Thanks,<br class=""> Alexandr.<br class=""><br class=""><br class="">On 12/01/16 13:34, Avik Niyogi wrote:<br class=""><blockquote type="cite" class="">Hi All,<br class=""><br class="">Please find the code changes in fix as with the inputs received for the same.<br class=""><a href="http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/" class="">http://cr.openjdk.java.net/~aniyogi/8015748/webrev.02/</a> <<a href="http://cr.openjdk.java.net/%7Eaniyogi/8015748/webrev.02/" class="">http://cr.openjdk.java.net/%7Eaniyogi/8015748/webrev.02/</a>><br class=""><br class="">With Regards,<br class="">Avik Niyogi<br class=""><br class=""><blockquote type="cite" class="">On 11-Jan-2016, at 3:55 pm, Semyon Sadetsky <<a href="mailto:semyon.sadetsky@oracle.com" class="">semyon.sadetsky@oracle.com</a> <<a href="mailto:semyon.sadetsky@oracle.com" class="">mailto:semyon.sadetsky@oracle.com</a>>> wrote:<br class=""><br class="">Hi Avik,<br class=""><br class="">Shouldn't the graphics transformation be restored before the paintString() call?<br class=""><br class="">It seems to me that left/right insets need to be swapped for right-to-left painting with mirroring graphics transformation.<br class=""><br class="">--Semyon<br class=""><br class="">On 1/5/2016 1:22 PM, Avik Niyogi wrote:<br class=""><blockquote type="cite" class="">Hi All,<br class="">Please find webrev with inputs as provided: <a href="http://cr.openjdk.java.net/~aniyogi/8015748/webrev.01/" class="">http://cr.openjdk.java.net/~aniyogi/8015748/webrev.01/</a><br class="">With Regards,<br class="">Avik Niyogi<br class=""><br class=""><blockquote type="cite" class="">On 23-Dec-2015, at 7:29 pm, Alexander Scherbatiy <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a>> wrote:<br class=""><br class=""><br class=""> - please check that the progress bar string (progressBar.setString()/setStringPainted()) is painted correctly.<br class=""> - is it possible to write an automated test for the fix?<br class=""><br class=""> Thanks,<br class=""> Alexandr.<br class=""><br class="">On 12/21/2015 11:47 AM, Avik Niyogi wrote:<br class=""><blockquote type="cite" class="">Hi All,<br class=""><br class="">Kindly review the bug fix for JDK 9.<br class=""><br class="">*Bug:*<br class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8015748" class="">https://bugs.openjdk.java.net/browse/JDK-8015748</a><br class=""><br class="">*Webrev:*<br class="">http://cr.openjdk.java.net/~aniyogi/8015748/webrev.00/ <http://cr.openjdk.java.net/%7Eaniyogi/8015748/webrev.00/><br class=""><br class="">*Issue:*<br class="">The manual test: Swing_JProgressbar/Manual/ProgressBarLAFTests/ProgressBarLAFTest1<br class=""> in testsuite http://sqe-hg.us.oracle.com/hg/index.cgi/testbase/javase/functional/7/swing fails<br class=""><br class="">*Cause:*<br class="">Due to not honouring of RIGHT_TO_LEFT parameter for setOrientation method applied for a JProgressBar for the AquaLookAndFeel only,<br class="">the progressBar does not have the ability to grow from right to left. This issue was verified to exist only in AquaLookAndFeel for JProgressBar.<br class=""><br class="">*Fix:*<br class="">Added implementation for the check of RIGHT_TO_LEFT ComponentOrientation and verified with other combination orientation with available<br class="">Horizontal and Vertical orientations as provided from before.<br class=""><br class="">With Regards,<br class="">Avik Niyogi<br class=""></blockquote><br class=""></blockquote><br class=""></blockquote><br class=""></blockquote><br class=""></blockquote><br class=""></blockquote><br class=""></blockquote><br class=""></div></blockquote></div><br class=""></div></body></html>