<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Prem,<br>
<br>
In the test<br>
getLocationOnScreen(), getBounds() and getNormalBounds() should be
called on EDT for Swing components.<br>
<br>
--Semyon<br>
<br>
<div class="moz-cite-prefix">On 2/15/2016 11:51 AM, Prem
Balakrishnan wrote:<br>
</div>
<blockquote cite="mid:3f7117c7-2a50-4951-a63f-5043052bdeaa@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle26
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Rajeev,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Test updated as
per your comments.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="color:#1F497D">Webrev:</span></b><span
style="color:#1F497D"> </span><span style="color:#1F497D"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/prem/7126823/webrev.02/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~arapte/prem/7126823/webrev.02/">http://cr.openjdk.java.net/~arapte/prem/7126823/webrev.02/</a></a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<br>
Prem<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
Rajeev Chamyal <br>
<b>Sent:</b> Monday, February 15, 2016 12:00 PM<br>
<b>To:</b> Prem Balakrishnan<br>
<b>Cc:</b> Sergey Bylokhov; Semyon Sadetsky; Alexander
Scherbatiy; Ambarish Rapte; <a class="moz-txt-link-abbreviated" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <Swing Dev> Review Request for
7126823 : JInternalFrame.getNormalBounds() returns bad
value after iconify/deiconify<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN">Hello
Prem,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN"><o:p> </o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span
style="color:#1F497D" lang="EN-IN">1)</span><span
style="font-size:7.0pt;font-family:"Times New
Roman","serif";color:#1F497D" lang="EN-IN">
</span><span style="color:#1F497D" lang="EN-IN">UI should be
created in a swing thread so please update the createUI
method to use a swing thread.<o:p></o:p></span></p>
<p class="MsoListParagraph" style="text-indent:-.25in"><span
style="color:#1F497D" lang="EN-IN">2)</span><span
style="font-size:7.0pt;font-family:"Times New
Roman","serif";color:#1F497D" lang="EN-IN">
</span><span style="color:#1F497D" lang="EN-IN">Also please
use SwingUtilities.invokeAndWait instead of
SwingUtilities.invokeLater.<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F497D"
lang="EN-IN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN">Rajeev
Chamyal<o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Prem Balakrishnan <br>
<b>Sent:</b> 11 February 2016 12:49<br>
<b>To:</b> Rajeev Chamyal<br>
<b>Cc:</b> Sergey Bylokhov; Semyon Sadetsky; Alexander
Scherbatiy; Ambarish Rapte; <a moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <Swing Dev> Review Request for
7126823 : JInternalFrame.getNormalBounds() returns bad
value after iconify/deiconify<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-IN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Rajeev,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I have tested
for all supported LAF’s across all platforms(Windows, Linux
and Mac)<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Test updated
for the same.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="color:#1F497D">Webrev:</span></b>
<span style="color:#1F497D"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/prem/7126823/webrev.01/">http://cr.openjdk.java.net/~arapte/prem/7126823/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Prem<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
Rajeev Chamyal <br>
<b>Sent:</b> Wednesday, February 10, 2016 2:00 PM<br>
<b>To:</b> Prem Balakrishnan<br>
<b>Cc:</b> Sergey Bylokhov; Semyon Sadetsky; Alexander
Scherbatiy; Ambarish Rapte; <a moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <Swing Dev> Review Request for
7126823 : JInternalFrame.getNormalBounds() returns bad
value after iconify/deiconify<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN">Hello
Prem,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN">Did
you test this fix for other LAF’s as well.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN">Rajeev
Chamyal<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D" lang="EN-IN"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Prem Balakrishnan <br>
<b>Sent:</b> 09 February 2016 14:40<br>
<b>To:</b> Sergey Bylokhov; Semyon Sadetsky; Alexander
Scherbatiy; Ambarish Rapte; <a moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a>;
<a moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> <Swing Dev> Review Request for
7126823 : JInternalFrame.getNormalBounds() returns bad
value after iconify/deiconify<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-IN"><o:p> </o:p></span></p>
<p class="MsoNormal">Hi<b>,</b><o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Please
review fix for JDK9,<o:p></o:p></p>
<p class="MsoNormal"><b><span style="color:#1F497D">Bug: </span></b><span
style="color:#1F497D"><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-7126823">https://bugs.openjdk.java.net/browse/JDK-7126823</a><o:p></o:p></span></p>
<p class="MsoNormal"><b><span style="color:#1F497D">Webrev:</span></b>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/prem/7126823/webrev.00/">http://cr.openjdk.java.net/~arapte/prem/7126823/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><b>Issue:<o:p></o:p></b></p>
<p class="MsoNormal">JInternalFrame.getNormalBounds() returns
bad value after iconify/deiconify<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><b>Cause:</b><o:p></o:p></p>
<p class="MsoNormal">Regression: due to 4424247:
DefaultDesktopManager does not handle InternalFrame state
changes as expected.<o:p></o:p></p>
<p class="MsoNormal"><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-4424247">https://bugs.openjdk.java.net/browse/JDK-4424247</a>
related to <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-4900778">https://bugs.openjdk.java.net/browse/JDK-4900778</a>
<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><b>Fix:<o:p></o:p></b></p>
<p class="MsoNormal">DefaultDesktopManager.java<b><o:p></o:p></b></p>
<p class="MsoNormal">setNormalBounds(getBounds()); call removed
from iconifyFrame(JInternalFrame f) method.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>Justification:<o:p></o:p></b></p>
<p class="MsoNormal">This fix is not breaking any of the
previous fix i.e., related to 4424247 and 4900778.<br>
(all previous scenarios are tested and validated with the
current fix)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">In JInternalFrame.java<o:p></o:p></p>
<p class="MsoNormal">getNormalBounds() returns getBounds() when
normalBounds is NULL, <o:p></o:p></p>
<p class="MsoNormal">Hence no need to setNormaBounds externally.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">public Rectangle getNormalBounds() {<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> /* we used to test (!isMaximum) here,
but since this<o:p></o:p></p>
<p class="MsoNormal"> method is used by the property
listener for the<o:p></o:p></p>
<p class="MsoNormal"> IS_MAXIMUM_PROPERTY, it ended up
getting the wrong<o:p></o:p></p>
<p class="MsoNormal"> answer... Since normalBounds get
set to null when the<o:p></o:p></p>
<p class="MsoNormal"> frame is restored, this should
work better */<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> if (normalBounds != null) {<o:p></o:p></p>
<p class="MsoNormal"> return normalBounds;<o:p></o:p></p>
<p class="MsoNormal"> } else {<o:p></o:p></p>
<p class="MsoNormal"> return getBounds();<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"> }<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">As per Javadoc: <br>
public Rectangle getNormalBounds() <br>
If the JInternalFrame is not in maximized state, returns
getBounds(); otherwise, returns the bounds that the
JInternalFrame would be restored to. <br>
<br>
In maximizeFrame() , normalBounds is set to a value which is
not NULL, i.e., setNormalBounds(getBounds()); <br>
In minimizeFrame(), normalBounds is set to NULL, i.e.,
setNormalBounds(null); <br>
NormalBounds should NOT be set elsewhere.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>Test:<o:p></o:p></b></p>
<p class="MsoNormal">Integrated test for current bug and
regression.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<br>
Prem<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>