<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">A meaningful name with some relevance
to what the test tests ?<br>
<br>
-phil.<br>
<br>
On 07/19/2016 12:03 PM, Pete Brunet wrote:<br>
</div>
<blockquote
cite="mid:12d13a6d-1522-4854-3669-dd1215291013@oracle.com"
type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<br>
<br>
<div class="moz-cite-prefix">On 7/19/16 1:52 PM, Phil Race wrote:<br>
</div>
<blockquote cite="mid:578E76E1.8000302@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">The fix is fine but as I've said
elsewhere I really don't like BugXXXXXX as test names.<br>
</div>
</blockquote>
Hi Phil, I haven't seen any of your prior comments about this
matter. I haven't seen any other style so just assumed that
is/was the standard. Is there an alternative standard I should
start to use?<br>
<br>
Pete<br>
<blockquote cite="mid:578E76E1.8000302@oracle.com" type="cite">
<div class="moz-cite-prefix"> <br>
-phil.<br>
<br>
On 07/19/2016 11:43 AM, Alexandr Scherbatiy wrote:<br>
</div>
<blockquote
cite="mid:3568fe5e-5eb4-a5d8-7658-421bc73103de@oracle.com"
type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
The fix looks good to me.<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<div class="moz-cite-prefix">On 7/19/2016 8:50 PM, Pete Brunet
wrote:<br>
</div>
<blockquote
cite="mid:e3711962-10a0-fd85-a686-3c2b440eeab7@oracle.com"
type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
Look at .02 instead. I had an extraneous println left in
.01.<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eptbrunet/JDK-8161483/webrev.02/">http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.02/</a><br>
<br>
<div class="moz-cite-prefix">On 7/19/16 11:48 AM, Pete
Brunet wrote:<br>
</div>
<blockquote
cite="mid:291686a7-8c0e-48a8-d894-69bc7dea4bba@oracle.com"
type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
I added a regression test:<br>
 <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eptbrunet/JDK-8161483/webrev.01/">http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.01/</a><br>
<br>
Could someone please review that?<br>
<br>
I also need one more +1 on the code change.<br>
<br>
TiA, Pete<br>
<br>
<div class="moz-cite-prefix">On 7/19/16 3:17 AM, Alexandr
Scherbatiy wrote:<br>
</div>
<blockquote
cite="mid:7a429ccd-f0d0-f403-08f0-bb42a1953a4b@oracle.com"
type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<br>
The fix looks good to me.<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<div class="moz-cite-prefix">On 7/19/2016 5:10 AM, Pete
Brunet wrote:<br>
</div>
<blockquote
cite="mid:f0e0b873-9cf4-7647-f108-73d9a9b48937@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
Please review the following:<br>
<br>
Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8161483">https://bugs.openjdk.java.net/browse/JDK-8161483</a><br>
Patch: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eptbrunet/JDK-8161483/webrev.00/">http://cr.openjdk.java.net/~ptbrunet/JDK-8161483/webrev.00/</a><br>
<br>
This is a followon to the patch for<br>
JDK-8145207 [macosx] JList, VO can't access
non-visible list items<br>
<br>
<meta charset="utf-8">
<span style="color: rgb(51, 51, 51); font-family:
sans-serif; font-size: 14px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 20px; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
1; word-spacing: 0px; -webkit-text-stroke-width:
0px; display: inline !important; float: none;
background-color: rgb(255, 255, 255);">In order to
fix<span class="Apple-converted-space"> </span></span>JDK-8145207<span
style="color: rgb(51, 51, 51); font-family:
sans-serif; font-size: 14px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 20px; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
1; word-spacing: 0px; -webkit-text-stroke-width:
0px; display: inline !important; float: none;
background-color: rgb(255, 255, 255);"><span
class="Apple-converted-space"> </span>the
AccessibleAction interface was needed for
JList.AccessibleJList.AccessibleJListChild but a
backport of this fix has been requested and the
released public API can not be changed in 8u or
earlier. The workaround for </span><span
style="color: rgb(51, 51, 51); font-family:
sans-serif; font-size: 14px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 20px; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
1; word-spacing: 0px; -webkit-text-stroke-width:
0px; display: inline !important; float: none;
background-color: rgb(255, 255, 255);">JDK-8145207
is to create and use a private subclass of
JList.AccessibleJList.AccessibleJListChild,
JList.AccessibleJList.ActionableAccessibleJListChild.Â
</span>The downside of this fix is that it returns a
subclass of the
JList.AccessibleJList.AccessibleJListChild. If a user
overrides the class and returns from its code it will
not inherit the AccessibleAction behavior. <span
style="color: rgb(51, 51, 51); font-family:
sans-serif; font-size: 14px; font-style: normal;
font-variant: normal; font-weight: normal;
letter-spacing: normal; line-height: 20px; orphans:
auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: normal; widows:
1; word-spacing: 0px; -webkit-text-stroke-width:
0px; display: inline !important; float: none;
background-color: rgb(255, 255, 255);">For JDK 9 the
</span><span style="color: rgb(51, 51, 51);
font-family: sans-serif; font-size: 14px;
font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal;
line-height: 20px; orphans: auto; text-align: start;
text-indent: 0px; text-transform: none; white-space:
normal; widows: 1; word-spacing: 0px;
-webkit-text-stroke-width: 0px; display: inline
!important; float: none; background-color: rgb(255,
255, 255);"><span style="color: rgb(51, 51, 51);
font-family: sans-serif; font-size: 14px;
font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal;
line-height: 20px; orphans: auto; text-align:
start; text-indent: 0px; text-transform: none;
white-space: normal; widows: 1; word-spacing: 0px;
-webkit-text-stroke-width: 0px; display: inline
!important; float: none; background-color:
rgb(255, 255, 255);">ActionableAccessibleJListChild
subclass</span> should be removed and the
AccessibleAction implementation moved to
JList.AccessibleJList.AccessibleJListChild.</span><br>
<br>
TiA,<br>
Pete </blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>