<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Hi Semyon,<br>
</p>
I missed that. I see now, the page mentions that "The first four
fields are standard for all file system folders"<br>
Column index
<table class="clsStd" summary="table" frame="box">
<tbody>
<tr>
<th scope="col" class=""><br>
</th>
<th scope="col">Column title</th>
</tr>
<tr>
<td data-th="Column index">0</td>
<td data-th="Column title">Name</td>
</tr>
<tr>
<td data-th="Column index">1</td>
<td data-th="Column title">Size</td>
</tr>
<tr>
<td data-th="Column index">2</td>
<td data-th="Column title">Type</td>
</tr>
<tr>
<td data-th="Column index">3</td>
<td data-th="Column title">Date Modified</td>
</tr>
</tbody>
</table>
<div class="moz-cite-prefix"><br>
so I modified webrev to rely on column index rather than string.<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~psadhukhan/8183529/webrev.02/">http://cr.openjdk.java.net/~psadhukhan/8183529/webrev.02/</a><br>
<br>
Regards<br>
Prasanta<br>
On 7/6/2017 9:01 PM, Semyon Sadetsky wrote:<br>
</div>
<blockquote type="cite"
cite="mid:ef333d69-a2a9-183f-593c-94bb96b2cc0d@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<p>Hi Prasanta,</p>
<p>See what MSDN says [1] about the column titles obtained by
IShellFolder2::GetDetailsOf:</p>
<p>... Bear in mind that these titles can be localized and might
not be the same for all locales.</p>
<p>--Semyon<br>
</p>
<p>[1]
<a class="moz-txt-link-freetext"
href="https://msdn.microsoft.com/en-us/library/windows/desktop/bb775053%28v=vs.85%29.aspx"
moz-do-not-send="true">https://msdn.microsoft.com/en-us/library/windows/desktop/bb775053(v=vs.85).aspx</a><br>
</p>
<br>
<div class="moz-cite-prefix">On 07/06/2017 01:13 AM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:bc7e9799-202f-42b4-70d2-f13d243cad38@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
Thanks Semyon for spotting this. Since this bug is for windows,
I concentrated on windows only.<br>
<br>
But it seems, for non-windows platform, ShellFolder uses <br>
COLUMN_NAME = "FileChooser.fileNameHeaderText";<br>
COLUMN_SIZE = "FileChooser.fileSizeHeaderText";<br>
COLUMN_DATE = "FileChooser.fileDateHeaderText";<br>
string which is locale-sensitive.<br>
<br>
Only for windows, it uses Win32ShellFolder which calls
IShellDetails::GetDetailsOf() to get columns details.<br>
Modified webrev applicable for only windows to convert this
windows specific names to locale-sensitive names.<br>
<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8183529/webrev.01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~psadhukhan/8183529/webrev.01/</a><br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 7/5/2017 8:40 PM, Semyon
Sadetsky wrote:<br>
</div>
<blockquote type="cite"
cite="mid:dffd5f3f-91c2-8c0a-66a1-1e82cbeb183d@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<p>Hi Prasanta,</p>
<p>Haven't you tested how the details header localization
works after your fix with other L&Fs and platforms?</p>
<p>--Semyon<br>
</p>
<br>
<div class="moz-cite-prefix">On 07/04/2017 11:42 PM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:26705aa8-4819-9bb1-7602-eea7570b09cc@oracle.com">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hi All,<br>
<br>
Please review a fix for a locale issue where it is seem
FileChooser dialog is not showing the column heading<br>
in selected locale in "Detail view mode".<br>
This was because, even though the locale strings are present
in properties resource file, <br>
<i>Â Â Â
share/classes/com/sun/java/swing/plaf/windows/resources/windows.properties</i><i><br>
</i><i>Â Â Â Â Â Â Â Â Â
FileChooser.fileNameHeader.textAndMnemonic=Name</i><i><br>
</i><i>Â Â Â Â Â Â Â Â Â
FileChooser.fileSizeHeader.textAndMnemonic=Size</i><i><br>
</i>the check done is wrong.<br>
<br>
Proposed fix is to check and get locale string resources
correctly.<br>
<br>
Bug: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8183529"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8183529</a><br>
webrev: <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Epsadhukhan/8183529/webrev.00/"
moz-do-not-send="true">http://cr.openjdk.java.net/~psadhukhan/8183529/webrev.00/</a><br>
<br>
Regards<br>
Prasanta<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>