<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Krishna,<br>
<br>
The fix looks good. But I did not understand the test. In my
understanding it should check that the next is not en empty:<br>
<br>
FileSystemView.getFileSystemView().getSystemDisplayName(FileSystemView.getFileSystemView().getShellFolder(new
File("C:\\")))<br>
<br>
And why do you run the test 50 times?<br>
<br>
--Semyon<br>
<br>
<div class="moz-cite-prefix">On 1/10/2018 7:57 AM, Jayathirth D V
wrote:<br>
</div>
<blockquote cite="mid:33acfa5b-bc66-4b95-a2d0-e7f9a5a0a186@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Times New Roman \,serif";}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:windowtext;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.changed
{mso-style-name:changed;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle26
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle27
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle28
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle29
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle30
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1155684722;
mso-list-type:hybrid;
mso-list-template-ids:1772512296 67698705 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-text:"%1\)";
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l1
{mso-list-id:1774595194;
mso-list-type:hybrid;
mso-list-template-ids:-355185038 67698705 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l1:level1
{mso-level-text:"%1\)";
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l1:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l1:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Krishna,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Changes are
fine.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Jay<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Krishna Addepalli <br>
<b>Sent:</b> Wednesday, January 10, 2018 8:17 PM<br>
<b>To:</b> Jayathirth D V; <a class="moz-txt-link-abbreviated" href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <Swing Dev>
[10][11][JDK-8194044] Regression manual Test
javax/swing/JFileChooser/8067660/FileChooserTest.java
fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Jay,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for the
suggestions, and I have created a new webrev here: </span><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekaddepalli/8194044/webrev03/">http://cr.openjdk.java.net/~kaddepalli/8194044/webrev03/</a><span
style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">However, I
don’t think Test if is a typo. It can be read as is and
still makes sense.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Krishna<o:p></o:p></span></p>
<p class="MsoNormal"><a moz-do-not-send="true"
name="_MailEndCompose"><span style="color:#1F497D"><o:p> </o:p></span></a></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Jayathirth D V <br>
<b>Sent:</b> Wednesday, January 10, 2018 6:18 PM<br>
<b>To:</b> Krishna Addepalli <<a
moz-do-not-send="true"
href="mailto:krishna.addepalli@oracle.com">krishna.addepalli@oracle.com</a>>;
<a moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <Swing Dev>
[10][11][JDK-8194044] Regression manual Test
javax/swing/JFileChooser/8067660/FileChooserTest.java
fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Krishna,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please find my
inputs:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="color:#1F497D"><span style="mso-list:Ignore">1)<span
style="font:7.0pt "Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F497D">There is no need for Starting and
Ending year in copyright of test case as it is a new file.
Adding just 2018 would be enough. <o:p></o:p></span></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="color:#1F497D"><span style="mso-list:Ignore">2)<span
style="font:7.0pt "Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F497D">Typo in jtreg summary : “Test if” it
should be “Tests if”.<o:p></o:p></span></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="color:#1F497D"><span style="mso-list:Ignore">3)<span
style="font:7.0pt "Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F497D">For multiline comments using /*..*/,
First line should be left empty in a block comment at Line
no 24 & 42 and last line of block comment should have
proper indentation at Line no 30. Java coding convention for
comments : <a moz-do-not-send="true"
href="http://www.oracle.com/technetwork/java/codeconventions-141999.html">http://www.oracle.com/technetwork/java/codeconventions-141999.html</a>
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Jay<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Krishna Addepalli <br>
<b>Sent:</b> Wednesday, January 10, 2018 6:00 PM<br>
<b>To:</b> Jayathirth D V; <a moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <Swing Dev>
[10][11][JDK-8194044] Regression manual Test
javax/swing/JFileChooser/8067660/FileChooserTest.java
fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Jay,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for your
time and review. I have incorporated your review comments
and created a new webrev here: </span><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekaddepalli/8194044/webrev02/">http://cr.openjdk.java.net/~kaddepalli/8194044/webrev02/</a><span
style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Krishna<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Jayathirth D V <br>
<b>Sent:</b> Wednesday, January 10, 2018 4:16 PM<br>
<b>To:</b> Krishna Addepalli <<a
moz-do-not-send="true"
href="mailto:krishna.addepalli@oracle.com">krishna.addepalli@oracle.com</a>>;
<a moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <Swing Dev>
[10][11][JDK-8194044] Regression manual Test
javax/swing/JFileChooser/8067660/FileChooserTest.java
fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Krishna,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please find my
inputs:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F4E79">Test case needs
to be updated with minor changes:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F4E79"><o:p> </o:p></span></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l1 level1 lfo4"><!--[if !supportLists]--><span
style="color:#1F4E79"><span style="mso-list:Ignore">1)<span
style="font:7.0pt "Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F4E79">Copyright information needs to be
added at the start of test file.<o:p></o:p></span></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l1 level1 lfo4"><!--[if !supportLists]--><span
style="color:#1F4E79"><span style="mso-list:Ignore">2)<span
style="font:7.0pt "Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F4E79">Jtreg test summary needs to be updated
to mention what the test is trying to achieve instead of JBS
bug title.<o:p></o:p></span></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l1 level1 lfo4"><!--[if !supportLists]--><span
style="color:#1F4E79"><span style="mso-list:Ignore">3)<span
style="font:7.0pt "Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F4E79">Also since this test is specific to
Windows we can remove the OS test code present in test case
with Jtreg @requires flag:<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F4E79"><o:p> </o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F4E79">Instead
of using the below code we can use @requires (os.family ==
"windows")<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F4E79"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:.25in"><span
style="color:#1F4E79"> if (OSInfo.getOSType() !=
OSInfo.OSType.WINDOWS) {<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F4E79">
System.out.println("The test is suitable only for Windows
OS. Skipped.");<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F4E79">
return;<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F4E79">
}<o:p></o:p></span></p>
<p class="MsoListParagraph"
style="text-indent:-.25in;mso-list:l1 level1 lfo4"><!--[if !supportLists]--><span
style="color:#1F4E79"><span style="mso-list:Ignore">4)<span
style="font:7.0pt "Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F4E79">For multiline comments at Line no 1
& 26 in test case please update the comment syntax to
use :<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F4E79">/*<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F4E79"> *<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F4E79"> *<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F4E79"> */<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Jay<o:p></o:p></span></p>
<p class="MsoListParagraph"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Krishna Addepalli <br>
<b>Sent:</b> Tuesday, January 09, 2018 2:30 PM<br>
<b>To:</b> Prasanta Sadhukhan; <a
moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: <Swing Dev>
[10][11][JDK-8194044] Regression manual Test
javax/swing/JFileChooser/8067660/FileChooserTest.java
fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi
Prasanta,Sergey,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I have added a
testcase along with the changes and created a new webrev : </span><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekaddepalli/8194044/webrev01/">http://cr.openjdk.java.net/~kaddepalli/8194044/webrev01/</a><span
style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please review
this and provide your comments.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Krishna<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Prasanta Sadhukhan <br>
<b>Sent:</b> Thursday, January 4, 2018 10:54 AM<br>
<b>To:</b> Krishna Addepalli <</span><a
moz-do-not-send="true"
href="mailto:krishna.addepalli@oracle.com">krishna.addepalli@oracle.com</a><span
style="color:windowtext">>; </span><a
moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><span
style="color:windowtext"><br>
<b>Subject:</b> Re: <Swing Dev>
[10][11][JDK-8194044] Regression manual Test
javax/swing/JFileChooser/8067660/FileChooserTest.java
fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>A regression test is added to prove that before your fix,
java was failing and after your fix is applied, it is passing
so it is not related to older/newer java versions. I saw we
already have
test/jdk/javax/swing/JFileChooser/6945316/bug6945316.java
which tests isFileSystemRoot. Maybe, we can do something
similar if it's not too much of a task.<span
style="font-size:12.0pt"><o:p></o:p></span></p>
<p class="MsoNormal">Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 1/3/2018 5:13 PM, Krishna Addepalli
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"><span style="color:#1F497D">Thanks for
the review Prasanta. However, I don’t see a point to write
a test case for isFileSystemRoot(), since, it is not going
to fail on any (older/newer) java versions, and it was
only introduced because of the fix for JDK-8175015.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Let me know
if you think otherwise.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Krishna</span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Prasanta Sadhukhan <br>
<b>Sent:</b> Wednesday, January 3, 2018 11:27 AM<br>
<b>To:</b> Krishna Addepalli </span><a
moz-do-not-send="true"
href="mailto:krishna.addepalli@oracle.com"><krishna.addepalli@oracle.com></a><span
style="color:windowtext">; </span><a
moz-do-not-send="true"
href="mailto:swing-dev@openjdk.java.net">swing-dev@openjdk.java.net</a><span
style="color:windowtext"><br>
<b>Subject:</b> Re: <Swing Dev>
[10][11][JDK-8194044] Regression manual Test
javax/swing/JFileChooser/8067660/FileChooserTest.java
fails</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p>Fix looks fine. But I guess, it is possible to add a
automated regression test to it utilising
isFileSystemRoot().<o:p></o:p></p>
<p class="MsoNormal">Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 1/2/2018 4:31 PM, Krishna Addepalli
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi All,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Please review a fix for bug:<o:p></o:p></p>
<p class="MsoNormal">Bug: JDK-8194044 : <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8194044">https://bugs.openjdk.java.net/browse/JDK-8194044</a><o:p></o:p></p>
<p class="MsoNormal">Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ekaddepalli/8194044/webrev00/">http://cr.openjdk.java.net/~kaddepalli/8194044/webrev00/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">This was caused due to the fix for
JDK-8175015, in which the line 446 in
Win32ShellFolderManager2.java was changed from
“getDrives()” to Win32ShellFolder2.listRoots().<o:p></o:p></p>
<p class="MsoNormal">While the earlier function returns an
object of Win32ShellFolder2, the latter returns an array
of Files. <o:p></o:p></p>
<p class="MsoNormal">The condition on line 450: “return
(sf.isFileSystem()&&sf.parent != null &&
sf.parent.equals(Win32ShellFolder2.listRoots())” was
returning false because of the wrong object being passed.
Earlier it was a Win32ShellFolder2 object, and the
comparision was done properly, but with the changes, the
equals fucnction was receiving a file array object, and
hence it was immediately returning false, leading to the
problem of empty strings being shown for Root drives.<o:p></o:p></p>
<p class="MsoNormal">The fix is to replace
“Win32ShellFolder2.listRoots()” with “getDrives()”
function. With this fix, the regression is addressed, as
well as the original JDK-8175015 which was a memory leak
issue.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Krishna<o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New Roman
\,serif""> </span><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman",serif"><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>