<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<tt><tt>I skimmed through the sources. It's good to see that this
patch<br>
is straight forward. A couple of comments:<br>
<br>
</tt>jdk.unsupported.desktop is defined to the application class
loader<br>
which I think it's fine as FX modules are defined to the same
class<br>
loader.<br>
<br>
I expect src/java.base/share/lib/security/default.security will<br>
need to be modified and grant permissions to
jdk.unsupported.desktop. <br>
Kevin and I talked about potential issues with running with
security<br>
manager enabled. Maybe it is a separate task to follow up and it
<br>
may reveal if any operation needs doPrivileged - that's fine with
me.<br>
<br>
The docs build starts with a known set of root modules for javadoc<br>
generation. I believe jdk.unsupported.desktop won't be included <br>
in the docs build which is intended (as it's unsupported). Can<br>
you verify it?<br>
<br>
Nit: </tt><tt><tt>jdk.swing.interop.* source files <br>
  </tt>it'd be good to keep import statements sorted by the
names.<br>
<br>
</tt>Mandy<br>
<br>
<div class="moz-cite-prefix">On 5/4/18 5:00 AM, Prasanta Sadhukhan
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:ded53e25-0a86-a8a8-03b9-56c2d5dc9abf@oracle.com">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Hi All,<br>
<br>
Please review an enhancement to remove the tight coupling of JDK
internal class from FX so that<br>
when javafx.* modules are removed from Openjdk build in jdk11, FX
in general, and fx swing interop, in particular, can still build
and function.<br>
<br>
Right now, FX uses 6 jdk internal packages<br>
sun.swing, sun.awt, java.awt.dnd.peer, sun.awt.dnd, sun.awt.image
and sun.java2d.<br>
<br>
However, the goal is not to use qualified exports of these
internal packages once FX is removed to be built along with JDK,<br>
<br>
The solution will define a new "jdk.unsupported.desktop" module
that exports public API <br>
that is intended to be used by the javafx.swing module (but it
does so with public exports and not qualified exports). <br>
The idea is the same as jdk.unsupported, in that it is documented
as being unsupported. <br>
Further, since it is only intended to be used by javafx.swing, it
need not be in the default module graph.<br>
<br>
The module-info.java will look like this:
<pre class="prettyprint"><code>module jdk.unsupported.desktop {
requires transitive java.desktop;
exports jdk.swing.interop;
}
</code><code></code>
</pre>
Enhancement: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8202199"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8202199</a>,
<a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8195811"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8195811</a><br>
webrev: cr.openjdk.java.net/~psadhukhan/fxswing.6/<br>
CSR: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8202175"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8202175</a><br>
<br>
Regards<br>
Prasanta<br>
<pre class="prettyprint"><code></code></pre>
<br>
</blockquote>
<br>
</body>
</html>