<div dir="ltr">Hi Prasanta,<div><br></div><div>As I understand, your solution sets default XPFillBorder to combobox in newer versions of windows except vista. </div><div>But then animated native border is not visible in win7 or win10.</div><div>I propose to add EmptyBorder 1px thick to see native border and calculate new size and position of arrow button.</div><div><br></div><div>please see my attached webrev<br></div><div><br></div><div>br,</div><div>Martin  <br></div><br><div class="gmail_quote"><div dir="ltr">pi 28. 9. 2018 o 6:27 Prasanta Sadhukhan <<a href="mailto:prasanta.sadhukhan@oracle.com" target="_blank">prasanta.sadhukhan@oracle.com</a>> napÃsal(a):<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<p>Hi Martin,<br>
</p>
<br>
<div class="m_-8363809487703665521m_3593652302377989070moz-cite-prefix">On 08-Sep-18 3:06 PM, Martin M wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi Prasanta,
<div><br>
</div>
<div>As far as I know, there are only 2 options in swing
on windows. WindowsLookAndFeel (includes XP theme, aero
for Vista, Win7, Win10...) and WindowsClassicLookAndFeel
(includes classic theme for win95, win98). </div>
<div>The fix was done for WindowsLookAndFeel, so it
affects not only Vista version but also win7 aero and
win10.</div>
<div><br>
</div>
<div>I think that EmptyBorder(0,0,0,0) should be replaced
by EmptyBorder(1,1,1,1) to see animated native border
and therefore BasicComboboxEditor will not be placed
over native border. But then arrowbutton will be placed
on wrong coordinates and also its size will not be ok.</div>
<div>I will create webrev with needed changes.</div>
<div><br>
</div>
</div>
</div>
</div>
</div>
</blockquote>
ok, but what is the problem with my webrev? The oldest supported
platform for jdk12, which is what my fix is targeted to, is windows
7 and the fix seems to work for windows 7 and windows10 as far I
have tested.<br>
If you see any problem with my webrev, please let me know <br>
or if you are ok, then please approve it<br>
or if you still insist on sending your webrev, then please send it
soon as we are already 2 months since my webrev is out for review.<br>
<br>
Regards<br>
Prasanta<br>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div>br,</div>
<div>Martin </div>
<br>
<div class="gmail_quote">
<div dir="ltr">št 6. 9. 2018 o 19:34 Prasanta Sadhukhan
<<a href="mailto:prasanta.sadhukhan@oracle.com" target="_blank">prasanta.sadhukhan@oracle.com</a>>
napÃsal(a):<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Ping? It's been a
month.<br>
<br>
Even if JDK-6490753 fix is not only for Vista, but a
portion of it <br>
[where I propose a fix] is causing issue in windows7,
10, so it is <br>
modified to make sure it works correctly in
windows7-10. It will also <br>
not affect windows vista.<br>
Please provide comments on this.<br>
<br>
Regards<br>
Prasanta<br>
On 8/9/2018 3:09 PM, Prasanta Sadhukhan wrote:<br>
> Gentle reminder.<br>
><br>
> I guess it's for vista as the bug description
states it's for<br>
><br>
> Vista Info:<br>
> ===========<br>
> Vista Build No: 5840<br>
> Vista Theme: Default Theme(Aero)<br>
><br>
> Regards<br>
> Prasanta<br>
> On 8/2/2018 12:27 AM, Sergey Bylokhov wrote:<br>
>> Hi, Prasanta.<br>
>> I am not sure that previous fix[JDK-6490753]
was implemented for <br>
>> Vista only.<br>
>> Maybe Martin (CC) can take a look to this?<br>
>><br>
>> On 01/08/2018 10:11, Prasanta Sadhukhan
wrote:<br>
>>> Hi All,<br>
>>><br>
>>> Please review a fix for an issue where it
is seen that combobox gets <br>
>>> an unwanted border around it.<br>
>>> This is a aftereffect of JDK-6490753 <br>
>>> <<a href="https://bugs.openjdk.java.net/browse/JDK-6490753" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-6490753</a>>
where am empty <br>
>>> border is added to combobox to make it
look like Vista native combobox.<br>
>>> Proposed fix is to make sure no empty
border is drawn if windows <br>
>>> version is not vista.<br>
>>> Here's the combobox looks like before and
after fix in windows 10 <br>
>>> and 7.<br>
>>><br>
>>> Before fix<br>
>>><br>
>>> After Fix<br>
>>><br>
>>> Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8203281" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8203281</a><br>
>>> webrev: <a href="http://cr.openjdk.java.net/%7Epsadhukhan/8203281/webrev.0/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~psadhukhan/8203281/webrev.0/</a><br>
>>><br>
>>> Regards<br>
>>> Prasanta<br>
>><br>
>><br>
><br>
<br>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote></div></div>