Nestmates MH tests update to use javac flag
maurizio.cimadamore at oracle.com
Thu Nov 24 14:38:52 UTC 2016
Looks good to me - note that I think that hotspot changes by themselves
might not be sufficient for having these test to pass - some upgrade to
the 292 machinery to take nestmates into account might also be in order.
On 24/11/16 11:56, Stanislav Smirnov wrote:
> please take a look on this changes to nestmates MH tests.
> Tests start using -XDdisableAccessors javac flag to stop generating access bridges and so verify the vm changes.
> Without vm support tests will fail on setUp phase because without access bridges there is no way to refer to “super” fields/methods from inner classes.
> Also in MethodHandleSubTop class lookup and mt access modifiers have been changed to package private to give access from inner classes without bridges.
> Rest of the changes verify that there are no access bridges available and some tests are now positive, expecting accessibility, plus added comments to the test cases.
> webrev: http://cr.openjdk.java.net/~stsmirno/mhtests/webrev.00
> And I will need a sponsor for this change.
> Best regards,
> Stanislav Smirnov
More information about the valhalla-dev