Nestmates MH tests update to use javac flag

Stanislav Smirnov stanislav.smirnov at oracle.com
Thu Nov 24 14:43:19 UTC 2016


Maurizio, thank you for a review.
Yes, 292 machinery requires upgrade, we have discussed it with Karen, not yet sure, who will be doing it, but thanks for pointing it out.

Best regards,
Stanislav Smirnov





> On 24 Nov 2016, at 17:38, Maurizio Cimadamore <maurizio.cimadamore at oracle.com> wrote:
> 
> Looks good to me - note that I think that hotspot changes by themselves might not be sufficient for having these test to pass - some upgrade to the 292 machinery to take nestmates into account might also be in order.
> 
> Maurizio
> 
> 
> On 24/11/16 11:56, Stanislav Smirnov wrote:
>> Hi,
>> 
>> please take a look on this changes to nestmates MH tests.
>> Tests start using -XDdisableAccessors javac flag to stop generating access bridges and so verify the vm changes.
>> Without vm support tests will fail on setUp phase because without access bridges there is no way to refer to “super” fields/methods from inner classes.
>> Also in MethodHandleSubTop class lookup and mt access modifiers have been changed to package private to give access from inner classes without bridges.
>> Rest of the changes verify that there are no access bridges available and some tests are now positive, expecting accessibility, plus added comments to the test cases.
>> 
>> webrev: http://cr.openjdk.java.net/~stsmirno/mhtests/webrev.00
>> 
>> And I will need a sponsor for this change.
>> 
>> Best regards,
>> Stanislav Smirnov
>> 
>> 
>> 
>> 
>> 
> 



More information about the valhalla-dev mailing list