Review Request: JDK-8185450: [MVT] ArrayLengthTest.java fails with NullPointerException

mandy chung mandy.chung at oracle.com
Thu Aug 10 00:07:07 UTC 2017


Right - the check is in valueComponent.

thanks for the review.
Mandy

On 8/9/17 4:50 PM, Maurizio Cimadamore wrote:
> Ah sorry!
>
> I missed the connection with valueComponent :-)
>
> Looks good
>
> Maurizio
>
>
> On 10/08/17 00:46, Maurizio Cimadamore wrote:
>> Why is the check on MethodHandle.arrayConstructor commented? The code 
>> is there in JDK 10.
>>
>> Maurizio
>>
>>
>> On 09/08/17 22:31, mandy chung wrote:
>>> A simple patch. MethodHandles::arrayXXX methods should detect if the 
>>> specified class is not an array type and throw IAE.  I piggyback in 
>>> this patch a small optimization in Class::isValueClass to return 
>>> false if value type is not enabled.
>>>
>>> http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8185450/webrev.00/index.html 
>>>
>>>
>>> Mandy
>>>
>>
>



More information about the valhalla-dev mailing list