RFR(L): 8185265 [MVT] improve performance of return of value types with new calling convention

Tobias Hartmann tobias.hartmann at oracle.com
Fri Aug 11 10:02:25 UTC 2017


Hi Roland,

On 11.08.2017 15:17, Roland Westrelin wrote:
> Here is a new webrev that addresses your comments:
> 
> http://cr.openjdk.java.net/~roland/8185265/webrev.01/
> 
> I changed my mind wrt UseTLAB: I changed the code in macro.cpp so it
> works with UseTLAB off.

Okay, looks good!

>> templateInterpreterGenerator_x86.cpp
>> - As I understand, a pack/unpack handler is always set if the value type can be returned in registers. Why do we need
>> the pack_handler != 0 check? Isn't the __ testptr(rax, 1) sufficient?
> 
> Yes, you're right about that.

Thanks for making these chances. As we've discussed, I'll try to debug the JPRT failure while you are out.

Best regards,
Tobias


More information about the valhalla-dev mailing list