RFR(S): 8186439: [MVT] ClassFileParser should ignore JVM_ACC_VALUE for class file version < 53.1
david.simms at oracle.com
Mon Aug 21 09:02:23 UTC 2017
On 21/08/17 10:57, Tobias Hartmann wrote:
> thanks for looking at this!
> On 21.08.2017 10:51, David Simms wrote:
>> src/share/vm/oops/instanceKlass.hpp: whitespace changes, from 2 to 4
>> spaces (style guide says 2) ? mistake, forgot to revert ?
> Actually, my change removes these excess whitespaces:
Hehe, my bad, reading backwards apparently. Good catch, thanks for that.
>> Minor point, "supports_value_types()" and with "EnableValhalla ||
>> EnableMVT" ?
> No, that does not work because even without EnableValhalla or
> EnableMVT we still load java.lang.__Value.
> We should probably add an assert/guarantee once we got rid of the
> __Value references.
Ah, yeah...thanks for the explanation
More information about the valhalla-dev