C2: multiple slices for flattened value type arrays

Tobias Hartmann tobias.hartmann at oracle.com
Thu Jan 12 14:54:58 UTC 2017


Hi Roland,

On 10.01.2017 15:50, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/valhalla/flattenvtarray/webrev.00/

Very nice!

I noticed some style issues you may want to correct since you changed those lines anyway:
- Excess newlines that can be removed. For example, type.hpp:1208, type.cpp:4486, type.cpp:4594
- Wrong indentations. For example, type.cpp:3071
- Excess/missing whitespace around parentheses. For example:
  - TypeRawPtr( PTR ptr, address bits ) -> TypeRawPtr(PTR ptr, address bits)
  - assert( offset() >= 0, "" ) -> assert(offset() >= 0, "")
  - _bits(bits){} -> _bits(bits) { }
- Pointer asterisk position. For example:
  - static const TypePtr *make(..) -> static const TypePtr* make(..)

You don't need to send a new webrev for that or we can also do that cleanup later.

Thanks,
Tobias

> 
> Roland.
> 


More information about the valhalla-dev mailing list