C2: multiple slices for flattened value type arrays

Roland Westrelin rwestrel at redhat.com
Fri Jan 13 14:34:30 UTC 2017


Hi Tobias,

> I noticed some style issues you may want to correct since you changed those lines anyway:
> - Excess newlines that can be removed. For example, type.hpp:1208, type.cpp:4486, type.cpp:4594
> - Wrong indentations. For example, type.cpp:3071
> - Excess/missing whitespace around parentheses. For example:
>   - TypeRawPtr( PTR ptr, address bits ) -> TypeRawPtr(PTR ptr, address bits)
>   - assert( offset() >= 0, "" ) -> assert(offset() >= 0, "")
>   - _bits(bits){} -> _bits(bits) { }
> - Pointer asterisk position. For example:
>   - static const TypePtr *make(..) -> static const TypePtr* make(..)
>
> You don't need to send a new webrev for that or we can also do that cleanup later.

Thanks for looking at this. I will do a quick pass of clean up and push
it.

Roland.


More information about the valhalla-dev mailing list