RFR: 8187817 [MVT] Crash with "assert(has_value_fields()) failed: Sanity checking" when inheriting value type fields

David Simms david.simms at oracle.com
Fri Oct 6 10:38:54 UTC 2017

Looks good !

On 5/10/2017 4:45 p.m., Frederic Parain wrote:
> Please, review this changeset fixing bug JDK-8187817.
> Most operation on value fields require to have a pointer to the
> ValueKlass of the field, and retrieving the ValueKlass is a
> costly operation. The InstanceKlass class has been extended
> to include an array of ValueKlass pointers for its fields,
> making the retrieval much faster.
> The bug was that the code not cirrectly handling the case
> where value fields were inherited from a parent class.
> Operations on the ValueKlass array were being performed on the
> current class and instead of the class where the fields were declared.
> http://cr.openjdk.java.net/~fparain/8187817/webrev.00/index.html
> An unit test is included.
> All hotspot_valhalla tests pass.
> Thank you,
> Fred

More information about the valhalla-dev mailing list