[Nestmates] RFR: 8188076: [Nestmates] Rename MemberOfNest attribute to NestHost

Karen Kinnear karen.kinnear at oracle.com
Mon Oct 16 11:42:49 UTC 2017


That was the recommendation of the EG. When I summarized that for Dan Smith he said ok - so I am assuming
that will show up in the next revision.

thanks,
Karen

> On Oct 16, 2017, at 7:27 AM, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Maurizio,
> 
> On 16/10/2017 7:49 PM, Maurizio Cimadamore wrote:
>> Hi David,
>> In some files (see below) some references to NestTop have been renamed - not sure whether this is deliberate, or just a find/replace issue
>> classFileParser.cpp
>> classFileParser.hpp
>> instanceKlass.cpp
>> instanceKlass.hpp
>> Can you please confirm I'm looking at the right bits? Note that your review email also seems inconsistent:
>> "The MemberOfNest attribute was renamed to NestHost. "
>> Ok, that matches my understanding...
>> "All references to nest-top now become nest-host."
>> That seems what's in the code, but is this correct?
> 
> Yes. While the attribute was MemberOfNest, we originally started referring to the "nest top" and that is the terminology I used in the VM implementation. But then it was suggested that it should be "nest host" and from that (eventually) came the renaming of the attribute. So I have changed all the uses (class names, variable names etc) from "nest top" to "nest host" in the VM code and tests.
> 
> Thanks,
> David
> 
>> Maurizio
>> On 13/10/17 07:19, David Holmes wrote:
>>> webrev: http://cr.openjdk.java.net/~dholmes/8188076/webrev/
>>> 
>>> The MemberOfNest attribute was renamed to NestHost.
>>> 
>>> All references to nest-top now become nest-host.
>>> 
>>> There are some additional changes in test/langtools/tools/javac/valhalla/nestmate/CheckNestmateAttrs.java that were missed in previous commits.
>>> 
>>> Thanks,
>>> David



More information about the valhalla-dev mailing list