[Nestmates] RFR: 8188076: [Nestmates] Rename MemberOfNest attribute to NestHost
maurizio.cimadamore at oracle.com
Mon Oct 16 12:14:36 UTC 2017
Ok, checked all files - everything looks good.
On 16/10/17 12:27, David Holmes wrote:
> Hi Maurizio,
> On 16/10/2017 7:49 PM, Maurizio Cimadamore wrote:
>> Hi David,
>> In some files (see below) some references to NestTop have been
>> renamed - not sure whether this is deliberate, or just a find/replace
>> Can you please confirm I'm looking at the right bits? Note that your
>> review email also seems inconsistent:
>> "The MemberOfNest attribute was renamed to NestHost. "
>> Ok, that matches my understanding...
>> "All references to nest-top now become nest-host."
>> That seems what's in the code, but is this correct?
> Yes. While the attribute was MemberOfNest, we originally started
> referring to the "nest top" and that is the terminology I used in the
> VM implementation. But then it was suggested that it should be "nest
> host" and from that (eventually) came the renaming of the attribute.
> So I have changed all the uses (class names, variable names etc) from
> "nest top" to "nest host" in the VM code and tests.
>> On 13/10/17 07:19, David Holmes wrote:
>>> webrev: http://cr.openjdk.java.net/~dholmes/8188076/webrev/
>>> The MemberOfNest attribute was renamed to NestHost.
>>> All references to nest-top now become nest-host.
>>> There are some additional changes in
>>> that were missed in previous commits.
More information about the valhalla-dev