[Nestmates] RFR (S) 8202401: [Nestmates] jshell tests fail due to class redefinition limitation on nested types

Jan Lahoda jan.lahoda at oracle.com
Mon Apr 30 14:18:29 UTC 2018


To me, looks OK.

Jan

On 30.4.2018 06:55, David Holmes wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8202401
> webrev: http://cr.openjdk.java.net/~dholmes/8202401/webrev/
>
> As jshell tries to use class redefinition when possible, it will hit
> errors if trying to redefine classes in a way that would modify the
> NestHost or NestMembers attributes. It then falls back to an alternative
> technique. For the tests this results in a "signature-change" that is
> unexpected.
>
> The simple fix (courtesy of Jan) is to change the "expects signature
> parameter" from false to true for those test cases.
>
> Thanks,
> David


More information about the valhalla-dev mailing list