[Nestmates] RFR (S) 8202401: [Nestmates] jshell tests fail due to class redefinition limitation on nested types

David Holmes david.holmes at oracle.com
Mon Apr 30 21:03:51 UTC 2018


Thanks Jan and Serguei.

David

On 1/05/2018 5:23 AM, serguei.spitsyn at oracle.com wrote:
> +1
> 
> Thanks,
> Serguei
> 
> 
> On 4/30/18 07:18, Jan Lahoda wrote:
>> To me, looks OK.
>>
>> Jan
>>
>> On 30.4.2018 06:55, David Holmes wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8202401
>>> webrev: http://cr.openjdk.java.net/~dholmes/8202401/webrev/
>>>
>>> As jshell tries to use class redefinition when possible, it will hit
>>> errors if trying to redefine classes in a way that would modify the
>>> NestHost or NestMembers attributes. It then falls back to an alternative
>>> technique. For the tests this results in a "signature-change" that is
>>> unexpected.
>>>
>>> The simple fix (courtesy of Jan) is to change the "expects signature
>>> parameter" from false to true for those test cases.
>>>
>>> Thanks,
>>> David
> 


More information about the valhalla-dev mailing list