RFR (XS) 8214426 [lworld][C1] aaload doesn't work with constant index

Ioi Lam ioi.lam at oracle.com
Sat Dec 1 00:59:50 UTC 2018


Hi Tobias,

Thanks for the review. I've folded the constant index and pushed the 
changeset.

I also did a 32-bit version of this, but the x86 build is broken so I 
can't test it. My code compiles, though :-)

Thanks

- Ioi

On 11/28/18 2:25 AM, Tobias Hartmann wrote:
> Hi Ioi,
>
> On 28.11.18 08:24, Ioi Lam wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8214426
>> http://cr.openjdk.java.net/~iklam/valhalla/8214426-aaload-const-index-crash.v01/
>>
>> The fix is to properly move the constant index into a register.
> But if the index is constant, we can statically fold the following shift_left and use a LIR_Const
> for the index_op, right?
>
>> With this fix, all tests in TestBasicFunctionality passed for C1:
> Great!
>
> Best regards,
> Tobias


More information about the valhalla-dev mailing list