[Nestmates] RFR: 8195827: [Nestmates] jdk/internal/reflect/MethodAccessorGenerator.java should generate invokeinterface for private interface methods

David Holmes david.holmes at oracle.com
Mon Jan 22 22:34:55 UTC 2018


On 23/01/2018 8:28 AM, Karen Kinnear wrote:
> Oops - this is the one I forgot to ask - do you have a test for this?

All the reflection tests are run twice e.g.

   29  * @run main TestReflection
   30  * @run main/othervm -Dsun.reflect.noInflation=true TestReflection
   31  */
   32
   33 // The first run will use NativeMethodAccessor and due to the 
limited number
   34 // of calls we will not reach the inflation threshold.
   35 // The second run disables inflation so we will use the 
GeneratedMethodAccessor
   36 // instead. In this way both sets of Reflection classes are tested.

> thanks,
> Karen
> 
> p.s. ignore my other email on 8195826 - not relevant.

Too late :)

Thanks,
David

>> On Jan 22, 2018, at 5:11 PM, Karen Kinnear <karen.kinnear at oracle.com> wrote:
>>
>> Looks good - thanks David!
>>
>> Karen
>>
>>> On Jan 22, 2018, at 1:30 AM, David Holmes <david.holmes at oracle.com> wrote:
>>>
>>> webrev: http://cr.openjdk.java.net/~dholmes/8195827/webrev/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8195827
>>>
>>> Simple update previously overlooked - thanks Karen! We no longer use invokespecial for private interface methods.
>>>
>>> Thanks,
>>> David
>>
> 


More information about the valhalla-dev mailing list